Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1010 and #1022 #1034

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Fixes #1010 and #1022 #1034

merged 3 commits into from
Jun 15, 2023

Conversation

AkashKarnatak
Copy link
Contributor

No description provided.

@AkashKarnatak
After [this](DLR-RM/stable-baselines3@9c338f9) by stable-baselines3…
c505d42 
…, DummyVecEnv.reset() method passes a `seed` argument to its list of envs. Since StockTradingEnv.reset() does not expect any argument it results in an error. This commit fixes AI4Finance-Foundation#1022.
@AkashKarnatak
DummyVecEnv.render() no longer returns the expected state after [this](…
311b1f4 
…DLR-RM/stable-baselines3#1327) pull request got merged in `stable-baselines3`. This commit fixes AI4Finance-Foundation#1010
@zhumingpassional
Copy link
Collaborator

thanks for your codes.
revison 1) last_state = trade_env.render()
last_state = trade_env.envs[0].render()
you revision aims to render the first env?

@zhumingpassional
Copy link
Collaborator

This branch has conflicts that must be resolved
could you pls revise it?

@AkashKarnatak
Copy link
Contributor Author

AkashKarnatak commented Jun 15, 2023 •
edited
Loading

thanks for your codes. revison 1) last_state = trade_env.render() last_state = trade_env.envs[0].render() you revision aims to render the first env?

yes, it tries to render the first env of DummyVecEnv.

@zhumingpassional zhumingpassional merged commit 5dcac3a into AI4Finance-Foundation:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AkashKarnatak @zhumingpassional