Create a scanner for hard-coded numbers

[larsvilhuber]

Blatantly cribbed from https://jpe-reproducibility.github.io/jpereplicators/replicator-resources.html#hard-coded-numbers

• Scanner should go through all code, and identify hard-coded numbers.
• Action taken if a code file has more than x hard-coded numbers, or multiple hard-coded numbers in a single line.

[floswald]

yes indeed, that's that this line is doing: https://github.com/JPE-Reproducibility/JPEtools.jl/blob/55d75baeba9d706b13051f4224b48d17d5d2fc34/src/actions.jl#L184

it picks up all numbers like 1.12345 or 111133.222 - the regex could be more refined!

it started out as your file path scanner but then I realized after having read all source code I might analyse if for a bunch of other things (the enclosing function name is not great).

[larsvilhuber]

OK, I see. You just print them out: https://github.com/JPE-Reproducibility/JPEtools.jl/blob/55d75baeba9d706b13051f4224b48d17d5d2fc34/src/actions.jl#L325 Wonder if we can identify some heuristic (like I sketched out) to flag some "suspicious" hardcodes.

…

-- Lars Vilhuber, Economist Cornell University p: +1.607-330-5743 https://calendly.com/larsvilhuber My working day may not be your working day. Please respond during your working day.

________________________________ From: Florian Oswald ***@***.***> Sent: Wednesday, September 3, 2025 12:55 To: AEADataEditor/replication-template-development ***@***.***> Cc: Lars Vilhuber ***@***.***>; Author ***@***.***> Subject: Re: [AEADataEditor/replication-template-development] Create a scanner for hard-coded numbers (Issue #67) [https://avatars.githubusercontent.com/u/1021558?s=20&v=4]floswald left a comment (AEADataEditor/replication-template-development#67)<#67 (comment)> yes indeed, that's that this line is doing: https://github.com/JPE-Reproducibility/JPEtools.jl/blob/55d75baeba9d706b13051f4224b48d17d5d2fc34/src/actions.jl#L184 it picks up all numbers like 1.12345 or 111133.222 - the regex could be more refined! it started out as your file path scanner but then I realized after having read all source code I might analyse if for a bunch of other things (the enclosing function name is not great). — Reply to this email directly, view it on GitHub<#67 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABVSQ6GUDZBSOBLOGXTABRD3Q4MP5AVCNFSM6AAAAACFRD5YHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENJQGAZDONZRGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>