Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for federation 2.9 directives #3355

Open
grzn opened this issue Nov 4, 2024 · 4 comments
Open

add support for federation 2.9 directives #3355

grzn opened this issue Nov 4, 2024 · 4 comments
Labels
apollo federation Related to Apollo federation

Comments

@grzn
Copy link

grzn commented Nov 4, 2024

What happened?

Currently when the schema uses any of the new directives, gqlgen errors:

Undefined directive listSize.

What did you expect?

Add support for the new directives
@StevenACoffman
Copy link
Collaborator

PRs are welcome!

@StevenACoffman StevenACoffman added federation Related to Apollo federation apollo labels Nov 7, 2024
@cyrilc-pro
Copy link

Just a suggestion to avoid such issues: add a config property to provide a set of schema files that must be "injected" by gqlgen, instead of hard-coding the Apollo Federation schema inside gqlgen.

@StevenACoffman
Copy link
Collaborator

@cyrilc-pro Great suggestion! Please make a PR!

@cyrilc-pro
Copy link

I'd be glad to, if I can find some time for it :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apollo federation Related to Apollo federation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grzn @StevenACoffman @cyrilc-pro