Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workflowRun Slack notification title for clarity #255

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

ham0215
Copy link
Contributor

@ham0215 ham0215 commented Oct 7, 2024

Currently, the Slack notification title for workflowRuns is the same as the workflow title. This makes it difficult to quickly understand the purpose of the notification from the Slack message.

This pull request proposes to change the workflowRun notification title to be more informative and distinct from the workflow title. This will improve the clarity of Slack notifications and make it easier to identify the specific action that triggered the notification.

@ham0215
Copy link
Contributor Author

ham0215 commented Oct 8, 2024

@8398a7
Could you please confirm this?

@ham0215
Copy link
Contributor Author

ham0215 commented Oct 8, 2024

Sorry, I'm not sure why, but Codecov seems to be throwing an error and causing CI to fail.

https://github.com/8398a7/action-slack/actions/runs/11235648383/job/31234107129?pr=255

==> Uploading reports
/home/runner/work/action-slack/action-slack/node_modules/codecov/lib/codecov.js:212
      } else if (result.split('\n').length !== 2) {
                        ^

TypeError: result.split is not a function
    at /home/runner/work/action-slack/action-slack/node_modules/codecov/lib/codecov.js:212:25
    at /home/runner/work/action-slack/action-slack/node_modules/teeny-request/build/src/index.js:217:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@8398a7
Copy link
Owner

8398a7 commented Oct 8, 2024

Here(#256) is the corrected version, so please merge the changes from master.

@ham0215
Copy link
Contributor Author

ham0215 commented Oct 8, 2024

Thanks for the fix! I've merged the changes from the master branch.

@ham0215
Copy link
Contributor Author

ham0215 commented Oct 10, 2024

@8398a7

Thanks for the fix! I've merged the changes from the master branch.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7d152f6) to head (f37bd55).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #255   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          254       254           
  Branches        82        82           
=========================================
  Hits           254       254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@8398a7 8398a7 merged commit 2ec70cd into 8398a7:master Oct 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants