-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Static primitive for sampler/scheduler (list widgets) #1
Comments
I have done some digging and I think it should be easy to add these as types. I'll get it working in not too long. |
As it turns out, there are already custom nodes designed specifically for that: selecting sampler/scheduler with a static type: Though, I believe such nodes should be in this pack, too (after all, that's it's sole purpose). Yep, kinda a duplicate functionality. but, on the other hand, it makes this pack self-contained for the purpose. |
I have added the new system. It fully works and is also expandable. Currently, there's still an issue with these nodes having very ugly output socket labels. I will try to fix this in a future update. |
Ok. Looking forward to this update then. |
This is just Manager. |
Maybe, it's a bug in the latest manager update. Or maybe, your repo is added to their DB twice. |
I'll ignore that issue for now |
The issue:
Sampler/scheduler inputs usually need to be connected to the same primitive as often as other
KSampler
inputs. So, they're subject to the same spaghetti un-wrangling this repo does. However, they're not float neither int nor string. And the only way to have them in a single place so far... is using the built-in primitive node.It would be nice to have a couple of additional static primitives for these specific two types, both acting the same way they do in KSampler: as dropdown-choice lists.
Ideally, there should be some kind of a universal "List Widget Static Primitive" node, with some way to link it to a specific list of available options. However, I have no idea if that's even possible.
I'm currently using a combo of this node pack +
Set
/Get
from KJNodes + UE Nodes, so I'm not sure which project is the best place to ask for such a functionality. But this one seems to be the closest one. Still, these issues are related:Set
/Get
list inputs kijai/ComfyUI-KJNodes#7The text was updated successfully, but these errors were encountered: