fix: ensure useSuspenseQuery data type does not include undefined#189
Merged
7nohe merged 3 commits into7nohe:mainfrom Dec 7, 2025
Merged
fix: ensure useSuspenseQuery data type does not include undefined#1897nohe merged 3 commits into7nohe:mainfrom
7nohe merged 3 commits into7nohe:mainfrom
Conversation
|
@isoppp is attempting to deploy a commit to the Daiki Urata's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Nice work! |
7nohe
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undefinedfromuseSuspenseQuerydata typeFixes #181
Changes
Type Fixes
UseSuspenseQueryOptionsimportDefaultResponsetype withNonNullablefor suspense queriesUseSuspenseQueryOptionsfor suspense query options parameterGenerated Code Changes
Before:
After:
Why NonNullable?
useSuspenseQueryenforcesthrowOnError: true, so errors are thrown and caught by ErrorBoundary. This meansdatais guaranteed to be defined when the component renders. Wrapping withNonNullableremovesundefinedfrom the type while maintaining consistency with the existingCommon.*type reference pattern.How to Test
pnpm buildpnpm vitest runpnpm run generate:api && pnpm run test:generatedinexamples/react-appdata.map()without optional chaining