Skip to content

Commit e2e12fa

Browse files
author
ChadKluck
committed
fix: update.py and config.py
1 parent d5f989d commit e2e12fa

File tree

7 files changed

+21
-15
lines changed

7 files changed

+21
-15
lines changed

SECURITY.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,9 @@
22

33
## Supported Versions
44

5-
Use this section to tell people about which versions of your project are
6-
currently being supported with security updates.
7-
85
| Version | Supported |
96
| ------- | ------------------ |
10-
| 1.x.x | :white_check_mark: |
7+
| 0.x.x | :white_check_mark: |
118

129
## Reporting a Vulnerability
1310

TODO.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@
55
- Default tags not saving to settings - Test prefix defaults, fix spacing, and showing of prefix heading when not needed.
66
- Save service role after service role deploy and make sure it is loaded in
77
- If deploy bucket is in param use s3 deploy and vice versa
8-
- CodeCommit and Repository tags being erroneously added
98
- Add Pull and Commit
10-
- Add: ask if user wants to run the deploy command
9+
- Add: ask if user wants to run the deploy script
1110
- Documentation
12-
- Fix tags - converting back and forth
11+
- Constant internal tag conversion from dictionary to list and back seems inefficient
1312

1413
## Deploy
1514

cli/CHANGELOG.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,20 @@
1-
# Changelog
1+
# CLI Script CHANGELOG
22

33
To update your local cli scripts from GitHub repository:
44

55
```bash
66
./cli/update.py
77
```
88

9-
## 0.0.5 (2025-06-xx)
9+
- The scripts are still in BETA and features are still being added and tested.
10+
- There may be several versions with small fixes released every few days until reaching v0.1.0.
11+
- After v0.1.0 all v0.0.x version change information will be removed from the Changelog.
12+
- Refer to [TODO](../TODO.md) for upcoming BETA fixes and features.
13+
- Report any issues not covered in TODO via the [Issues page in the GitHub repository](https://github.com/63Klabs/atlantis-cfn-configuration-repo-for-serverless-deployments/issues)
1014

11-
Mostly stable.
15+
## v0.0.5 (2025-06-07)
16+
17+
Mostly stable. Still in Beta.
18+
19+
- Fixed issue where update.py was not pulling latest changes from organization's SAM config repository.
20+
- Fixed issue where CodeCommit and Repository tags being erroneously added to the tag prompts for the user even though they are automatically managed.

cli/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1114,7 +1114,7 @@ def parse_parameter_overrides(self, parameter_string: str) -> Dict:
11141114
Input: 'ParameterKey1=value1 ParameterKey2="value 2"'
11151115
Output: {'ParameterKey1': 'value1', 'ParameterKey2': 'value 2'}
11161116
"""
1117-
1117+
11181118
parameters: Dict[str, str] = {}
11191119

11201120
if not parameter_string:

cli/lib/atlantis.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def is_atlantis_reserved_tag(key: str) -> bool:
8181
Returns:
8282
bool: True if the tag key is not a reserved Atlantis tag
8383
"""
84-
return (key.startswith('Atlantis') or key.startswith('atlantis:') or key in ['Provisioner', 'DeployedUsing', 'Name', 'Stage', 'Environment', 'AlarmNotificationEmail'])
84+
return (key.startswith('Atlantis') or key.startswith('atlantis:') or key in ['Provisioner', 'DeployedUsing', 'Name', 'Stage', 'Environment', 'AlarmNotificationEmail', 'Repository', 'RepositoryBranch', 'CodeCommitRepository', 'CodeCommitBranch'])
8585

8686
@staticmethod
8787
def prompt_for_tags(tags: Dict) -> Dict:

cli/update.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env python3
22

3-
VERSION = "v0.1.0/2025-03-30"
3+
VERSION = "v0.1.3/2025-06-05"
44
# Created by Chad Kluck with AI assistance from Amazon Q Developer
55

66
import os
@@ -532,7 +532,7 @@ def pull_changes(self) -> bool:
532532
if choice not in ['YES', 'NO']:
533533
click.echo(Colorize.error("Please enter 'YES' or 'NO'"))
534534

535-
if choice.strip().lower() == 'YES':
535+
if choice.strip().upper() == 'YES':
536536
ConsoleAndLog.info("Pulling latest changes...")
537537
subprocess.run(
538538
["git", "pull"],

defaults/defaults.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
"ServiceRolePath": "/service-role/",
99
"S3BucketNameOrgPrefix": "xcme",
1010
"S3ArtifactsBucket": "cf-asdf-deployments",
11-
"ParameterStoreHierarchy": "/"
11+
"ParameterStoreHierarchy": "/",
12+
"PermissionsBoundaryArn": "arn:aws:iam::123456789012:policy/MyPermissionsBoundary"
1213
},
1314
"tags": []
1415
}

0 commit comments

Comments
 (0)