updated update.py see changelog

Author: ChadKluck

cli/CHANGELOG.md

@@ -12,10 +12,61 @@ To update your local cli scripts from GitHub repository:
 - Refer to [TODO](../TODO.md) for upcoming BETA fixes and features.
 - Report any issues not covered in TODO via the [Issues page in the GitHub repository](https://github.com/63Klabs/atlantis-cfn-configuration-repo-for-serverless-deployments/issues)
 
-## v0.0.7 (2025-06-xx)
+## v0.0.8 (2025-06-xx)
 
 Upcoming
 
+## v0.0.7 (2025-06-10)
+
+Mostly stable. Still in Beta.
+
+I'm going to go into a little more detail than usual.
+
+- update.py (v0.1.5/2025-06-10): Fixed issue where the downloaded release zip file does not contain the `v` in front of the version number even if the release tag in GitHub has the `v`. This irregularity lies in GitHub and is a weird quirk that according to my conversation with GitHub Copilot is "undocumented but reproducible." This is even experienced when downloading a zip directly from the release page. The link will point to `<url>/v0.0.6.zip`, but the downloaded file will be `<repo-name>-0.0.6.zip` with files extracted to `<repo-name>-0.0.6.zip`.
+- For the fix, GitHub Copilot recommended that instead of constructing the path beforehand, look inside the zip file and see what the actual path is. This should hopefully fix any future issue.
+
+Below is GitHub Copilot's explanation. (Note: it says "This is a GitHub quirk for repositories with a dash (`-`) in the tag name" but there isn't a dash in the tag name, so there is still some inconsistencies as to why this happens.) However, I provide this information because:
+
+1. GitHub Copilot admitted I was right :)
+2. "This is not documented by GitHub, but is reproducible and widely observed." (so there could still be other quirks that need to be accounted for in the future)
+
+### From GitHub Copilot
+
+Thank you for the detailed info and the direct observation.
+
+You are correct: **the downloaded file is named**  
+
+```
+atlantis-cfn-configuration-repo-for-serverless-deployments-0.0.6.zip
+```
+**even though the tag is `v0.0.6`.**
+
+#### Why does this happen?
+
+This is a GitHub quirk for repositories with a dash (`-`) in the tag name.
+
+GitHub strips the leading `v` from the zip file and folder name **if the tag is in the format `vX.Y.Z`**.
+
+- The actual tag in the repo is still `v0.0.6`.
+- The zip file and extracted folder are named as if the tag is `0.0.6`.
+
+**This is not documented by GitHub, but is reproducible and widely observed.**
+
+#### What does this mean for your code?
+
+Your code currently does:
+
+```python
+zipped_dir = f"{repo}-{tag}/"
+```
+
+If `tag` is `v0.0.6`, but the extracted folder is `atlantis-cfn-configuration-repo-for-serverless-deployments-0.0.6/`, your code will not find the right directory.
+
+#### Summary
+
+- GitHub sometimes strips the leading `v` from zip/folder names for tags like `v0.0.6`.
+- Adjust your code to check for both possibilities.
+
 ## v0.0.6 (2025-06-09)
 
 Mostly stable. Still in Beta.

cli/update.py

@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 
-VERSION = "v0.1.4/2025-06-09"
+VERSION = "v0.1.5/2025-06-10"
 # Created by Chad Kluck with AI assistance from Amazon Q Developer
 
 import os
@@ -342,19 +342,39 @@ def update_from_zip(self, zip_location: str ) -> bool:
 
             # If the zip file is from github, then the extracted base path will be <repo>-<tag>
             zipped_dir = ""
-            if self.src_type == "github":
-                result = self.get_github_repo_info(self.source)
-                repo = result['repo']
-                tag = result['tag']
+            # if self.src_type == "github":
+            #     result = self.get_github_repo_info(self.source)
+            #     repo = result['repo']
+            #     tag = result['tag']
+
+            #     if tag == "":
+            #         tag = "main"
 
-                if tag == "":
-                    tag = "main"
-                zipped_dir = f"{repo}-{tag}/"
+            #     print(f"Repo: {repo} Tag: {tag}")
+            #     zipped_dir = f"{repo}-{tag}/"
 
-            ConsoleAndLog.info(f"Extracted directory: {zipped_dir}")
-            ConsoleAndLog.info(f"Target directories: {self.target_dirs}")
+            # print(f"Zipped dir: {zipped_dir}")
+
+            # ConsoleAndLog.info(f"Extracted directory: {zipped_dir}")
+            # ConsoleAndLog.info(f"Target directories: {self.target_dirs}")
 
             with zipfile.ZipFile(zip_location, 'r') as zip_ref:
+
+                # Dynamically detect the top-level directory in the zip
+                top_level_dirs = set(
+                    file_info.filename.split('/')[0]
+                    for file_info in zip_ref.filelist
+                    if '/' in file_info.filename
+                )
+                if self.src_type == "github" and top_level_dirs:
+                    # There should be only one top-level directory in a GitHub zip
+                    zipped_dir = list(top_level_dirs)[0] + "/"
+
+                print(f"Zipped dir: {zipped_dir}")
+
+                ConsoleAndLog.info(f"Extracted directory: {zipped_dir}")
+                ConsoleAndLog.info(f"Target directories: {self.target_dirs}")
+
                 # Extract only the directories we want
                 for file_info in zip_ref.filelist:
                     for target_dir in self.target_dirs: