Node 4 compat

Author: geowarin

.travis.yml

@@ -1,5 +1,7 @@
 language: node_js
 node_js:
+  - 4
+  - 5
   - 6
 
 cache:

src/core/extractWebpackError.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const RequestShortener = require("webpack/lib/RequestShortener");
 
 // TODO: allow the location to be customized in options

src/core/formatErrors.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Applies formatters to all AnnotatedErrors.
  *

src/core/transformErrors.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const extractError = require('./extractWebpackError');
 
 /**

src/debug.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const stripAnsi = require('strip-ansi');
 const chalk = require('chalk');
 
@@ -24,26 +26,26 @@ class Debugger {
     this.capturedMessages = [];
   }
 
-  log (...args) {
+  log () {
     if (this.enabled) {
-      this.captureConsole(args, console.log);
+      this.captureConsole(Array.from(arguments), console.log);
     }
   }
 
-  info (...args) {
+  info () {
     if (this.enabled) {
-      this.captureConsole(args, console.info, 'green');
+      this.captureConsole(Array.from(arguments), console.info, 'green');
     }
   }
 
-  error (...args) {
+  error () {
     // always show errors
-    this.captureConsole(args, console.error, 'red');
+    this.captureConsole(Array.from(arguments), console.error, 'red');
   }
 
-  warn (...args) {
+  warn () {
     if (this.enabled) {
-      this.captureConsole(args, console.warn, 'yellow');
+      this.captureConsole(Array.from(arguments), console.warn, 'yellow');
     }
   }
 

src/formatters/defaultError.js

@@ -1,13 +1,15 @@
+'use strict';
+
 const chalk = require('chalk');
 
-function displayError(index, severity, { file, message, origin }) {
+function displayError(index, severity, error) {
   const baseError = chalk.red(`${index + 1}) ${severity}`);
 
   return [
-    `${baseError} ${file ? 'in ' + file : ''}`,
+    `${baseError} ${error.file ? 'in ' + error.file : ''}`,
     '',
-    message,
-    (origin ? origin : undefined),
+    error.message,
+    (error.origin ? error.origin : undefined),
     ''
   ].filter(chunk => chunk !== undefined);
 }

src/formatters/moduleNotFound.js

@@ -1,34 +1,35 @@
-function dependenciesNotFound(count) {
+'use strict';
+
+function dependenciesNotFound (count) {
   if (count === 1) {
     return 'This dependency was not found in node_modules:';
   }
 
   return 'These dependencies were not found in node_modules:';
 }
 
-function forgetToInstall(count) {
+function forgetToInstall (count) {
   if (count === 1) {
     return 'Did you forget to run npm install --save for it?';
   }
 
   return 'Did you forget to run npm install --save for them?';
 }
 
-function formatErrors(errors) {
+function formatErrors (errors) {
   if (errors.length === 0) {
     return [];
   }
 
   return [
     dependenciesNotFound(errors.length),
-    '',
-    ...errors.map(({ module }) =>`* ${module}`),
-    '',
-    forgetToInstall(errors.length),
-  ];
+    ''
+  ]
+    .concat(errors.map(e =>`* ${e.module}`))
+    .concat('', forgetToInstall(errors.length));
 }
 
-function format(errors) {
+function format (errors) {
   return formatErrors(errors.filter((e) => (
     e.type === 'module-not-found'
   )));

src/friendly-errors-plugin.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const path = require('path');
 const chalk = require('chalk');
 const os = require('os');
@@ -25,10 +27,11 @@ const LOGO = path.join(__dirname, 'tarec_logo_ico.png');
 
 class FriendlyErrorsWebpackPlugin {
 
-  constructor ({notificationTitle, compilationSuccessMessage, showNotifications} = {}) {
-    this.notificationTitle = notificationTitle;
-    this.compilationSuccessMessage = compilationSuccessMessage;
-    this.notifier = showNotifications && safeRequire('node-notifier');
+  constructor (options) {
+    options = options || {};
+    this.notificationTitle = options.notificationTitle;
+    this.compilationSuccessMessage = options.compilationSuccessMessage;
+    this.notifier = options.showNotifications && safeRequire('node-notifier');
   }
 
   notify (serverity, error) {

src/transformers/babelSyntax.js

@@ -1,3 +1,5 @@
+'use strict';
+
 function cleanStackTrace(message) {
   return message
     .replace(/^\s*at\s.*:\d+:\d+[\s\)]*\n/gm, ''); // at ... ...:x:y

src/transformers/moduleNotFound.js

@@ -1,7 +1,9 @@
+'use strict';
+
 const TYPE = 'module-not-found';
 
-function isModuleNotFoundError(e) {
-  const { webpackError = {} } = e;
+function isModuleNotFoundError (e) {
+  const webpackError = e.webpackError || {};
   return webpackError.dependencies && webpackError.dependencies.length &&
     (e.type === TYPE ||
      e.name === 'ModuleNotFoundError' &&