Add .eslintrc and .editorconfig #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "no-unneeded-ternary": 2, | ||
| "object-curly-spacing": 2, | ||
| "one-var": 2, | ||
| "one-var": [2, "never"], |
| "extends": "./.eslintrc-default", | ||
| "env": { | ||
| "browser": true, | ||
| "node": true, |
There was a problem hiding this comment.
I don't think we need this anymore now we are using es6 modules.
|
👍 |
richardscarrott
added a commit
that referenced
this pull request
Jul 5, 2015
Add .eslintrc and .editorconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mderrick @albertkang
I've merged our eslint rules -- you might want to check over them as it was hard to diff them as my list didn't contain any of the eslint default rules so let me know if you notice any that I've omitted.
The differences I found were:
"no-reserved-keys": 2however I don't think we need this as we're going to be compiling our client side code from es6 to es3 syntax."valid-jsdoc": 1rather than"valid-jsdoc": 2so I went with yours.Once this is merged in I'll make a change to the boilerplate to use these linting rules. With re: to
.editorconfigI think we'll have to create a gulp task which copies it from this repo on demand (and check the copy into the boilerplate).Also I'll add a
.eslintignorercto the boilerplate to ignorenode_modules