Use QStringLiteral() instead QString()

Use QStringLiteral for compile time string construction.

Author: bokic

QFontIcon/qfonticon.h

@@ -64,7 +64,7 @@ class QFontIcon : public QObject
     static bool addFont(const QString& filename);
     static QFontIcon * instance();
     // main methods. Return icons from code
-    static QIcon icon(const QChar& code, const QColor& baseColor = QColor(),const QString& family = QString());
+    static QIcon icon(const QChar& code, const QColor& baseColor = QColor(),const QString& family = QStringLiteral());
     // return added fonts
     const QStringList& families() const;
 

analysis/analysis.cpp

@@ -36,8 +36,8 @@ void Analysis::save(const QString &path)
 {
     QString name = metaObject()->className();
     QDir dir(path);
-    QString svgPath = dir.filePath(QString("%1.svg").arg(name));
-    QString pngPath = dir.filePath(QString("%1.png").arg(name));
+    QString svgPath = dir.filePath(QStringLiteral("%1.svg").arg(name));
+    QString pngPath = dir.filePath(QStringLiteral("%1.png").arg(name));
 
     capture(svgPath);
     capture(pngPath, ImageFormat::PngFormat);

analysis/basicstatsanalysis.cpp

@@ -77,7 +77,7 @@ QWidget *BasicStatsAnalysis::createResultWidget()
     KeyValueModel * model = new KeyValueModel(view);
     view->setModel(model);
 
-    QString length = mMinLength == mMaxLength ? QString::number(mMaxLength) :  QString("%1-%2").arg(mMinLength).arg(mMaxLength);
+    QString length = mMinLength == mMaxLength ? QString::number(mMaxLength) :  QStringLiteral("%1-%2").arg(mMinLength).arg(mMaxLength);
 
 
     model->addValue(tr("Total Sequences"), QLocale::system().toString(mReadCount));
@@ -113,7 +113,7 @@ void BasicStatsAnalysis::save(const QString &path)
     QJsonObject json;
 
     QDir dir(path);
-    QString filename = dir.filePath(QString("%1.json").arg(metaObject()->className()));
+    QString filename = dir.filePath(QStringLiteral("%1.json").arg(metaObject()->className()));
 
     QFile file(filename);
     if (file.open(QIODevice::WriteOnly))

analysis/overrepresentedseqsanalysis.cpp

@@ -89,8 +89,8 @@ QWidget *OverRepresentedSeqsAnalysis::createResultWidget()
 void OverRepresentedSeqsAnalysis::save(const QString &path)
 {
     QDir dir(path);
-    QString tsvPath     = dir.filePath(QString("%1.tsv").arg(metaObject()->className()));
-    QString fastaPath   = dir.filePath(QString("%1.fasta").arg(metaObject()->className()));
+    QString tsvPath     = dir.filePath(QStringLiteral("%1.tsv").arg(metaObject()->className()));
+    QString fastaPath   = dir.filePath(QStringLiteral("%1.fasta").arg(metaObject()->className()));
 
     QFile tsvFile(tsvPath);
     QFile fastaFile(fastaPath);
@@ -106,7 +106,7 @@ void OverRepresentedSeqsAnalysis::save(const QString &path)
         {
             double percentage = ((double)mSequences[s] / mCount) * 100;
             tsvStream<<s<<"\t"<<mSequences[s]<<"\t"<<percentage<<"\n";
-            fastaStream<<QString(">Seq_%1;count=%2;percentage=%3").arg(index).arg(mSequences[s]).arg(percentage)<<"\n";
+            fastaStream<<QStringLiteral(">Seq_%1;count=%2;percentage=%3").arg(index).arg(mSequences[s]).arg(percentage)<<"\n";
             fastaStream<<s<<endl;
 
             ++index;

analysis/perbasequalityanalysis.cpp

@@ -298,7 +298,7 @@ void PerBaseQualityAnalysis::computePercentages()
     highest.fill(0,groups.length());
     lowerQuartile.fill(0,groups.length());
     upperQuartile.fill(0,groups.length());
-    xLabels.fill(QString(), groups.length());
+    xLabels.fill(QStringLiteral(), groups.length());
 
     for (int i=0;i<groups.length();i++) {
         int minBase = groups[i].lowerCount();

main.cpp

@@ -45,7 +45,7 @@ int main(int argc, char *argv[])
     QString locale = QLocale::system().name().section('_', 0, 0);
 
     QTranslator translator;
-    translator.load(QString("localization/fastqc_")+locale);
+    translator.load(QStringLiteral("localization/fastqc_")+locale);
     a.installTranslator(&translator);
 
 

model/keyvaluemodel.h

@@ -34,7 +34,7 @@ class KeyValueModel : public QAbstractListModel
 public:
     KeyValueModel(QObject * parent = 0);
 
-    void addValue(const QString& label, const QVariant& value, const QString& description = QString());
+    void addValue(const QString& label, const QVariant& value, const QString& description = QStringLiteral());
 
 
 

sequence/phredencoding.cpp

@@ -33,7 +33,7 @@ PhredEncoding PhredEncoding::fastqEncodingOffset(char lowestChar)
     qDebug()<< int(lowestChar);
 
     if (lowestChar < 33){
-        qCritical()<<QString("No known encodings with chars < 33 (Yours was %1)").arg(lowestChar);
+        qCritical()<<QStringLiteral("No known encodings with chars < 33 (Yours was %1)").arg(lowestChar);
         return PhredEncoding();
     }
     else if (lowestChar < 64)
@@ -51,7 +51,7 @@ PhredEncoding PhredEncoding::fastqEncodingOffset(char lowestChar)
         return PhredEncoding("Illumina 1.5", ILLUMINA_1_3_ENCODING_OFFSET);
     }
 
-    qCritical()<<QString("No known encodings with chars > 126 (Yours was %1)").arg(lowestChar);
+    qCritical()<<QStringLiteral("No known encodings with chars > 126 (Yours was %1)").arg(lowestChar);
     return PhredEncoding();
 
 }

sequence/phredencoding.h

@@ -30,7 +30,7 @@ Copyright Copyright 2016-17 Sacha Schutz
 class PhredEncoding
 {
 public:
-    PhredEncoding(const QString& n = QString(), int offset = 0);
+    PhredEncoding(const QString& n = QStringLiteral(), int offset = 0);
 
     static PhredEncoding fastqEncodingOffset(char lowestChar);
     bool isValid();

ui/aboutdialog.cpp

@@ -31,7 +31,7 @@ AboutDialog::AboutDialog(QWidget * parent)
     addTab(":/text/CHANGELOG");
 
     mTitle = qApp->applicationName();
-    mSubtitle = QString("Version %1\nGPL3 Copyright (C) 2017\nLabsquare.org").arg(qApp->applicationVersion());
+    mSubtitle = QStringLiteral("Version %1\nGPL3 Copyright (C) 2017\nLabsquare.org").arg(qApp->applicationVersion());
     drawHeader();
 
     setWindowTitle(tr("About %1").arg(qApp->applicationName()));

ui/mainanalyseview.cpp

@@ -29,7 +29,7 @@ void MainAnalyseDelegate::paint(QPainter *painter, const QStyleOptionViewItem &o
         progressBarOption.maximum = progress == -1 ? 0 : 100;
         progressBarOption.textAlignment = Qt::AlignCenter;
         progressBarOption.progress = progress;
-        progressBarOption.text = progress == -1 ? QString("∞") : QString ( "%1%" ).arg ( progress );
+        progressBarOption.text = progress == -1 ? QStringLiteral("∞") : QStringLiteral( "%1%" ).arg ( progress );
         progressBarOption.textVisible = true;
         QApplication::style()->drawControl ( QStyle::CE_ProgressBar, &progressBarOption, painter );
 

utils/basegroup.cpp

@@ -53,7 +53,7 @@ QString BaseGroup::toString() const
     if (lowerCount() == upperCount())
         return QString::number(lowerCount());
     else
-        return QString("%1-%2").arg(lowerCount()).arg(upperCount());
+        return QStringLiteral("%1-%2").arg(lowerCount()).arg(upperCount());
 }
 
 QVector<BaseGroup> BaseGroup::makeBaseGroups(int maxLength)
@@ -228,7 +228,7 @@ int BaseGroup::getLinearInterval(int length)
         multiplier *= 10;
 
         if (multiplier == 10000000) {
-            qCritical()<<Q_FUNC_INFO<<QString("Couldn't find a sensible interval grouping for length '%1'").arg(length);
+            qCritical()<<Q_FUNC_INFO<<QStringLiteral("Couldn't find a sensible interval grouping for length '%1'").arg(length);
         }
     }
 }