This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
feat: warning element for threshold changes/delegate calls #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
May 6, 2022
src/routes/safe/components/Transactions/TxList/AlertTooltipWarning.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Transactions/TxList/DelegateCallWarning.tsx
Outdated
Show resolved
Hide resolved
| const ThresholdWarning = (): ReactElement => ( | ||
| <AlertTooltipWarning | ||
| tooltip="This transaction alters the number of confirmations required to execute a transaction." | ||
| warning="Confirmation policy change" |
Pull Request Test Coverage Report for Build 2280703343
💛 - Coveralls |
usame-algan
reviewed
May 6, 2022
src/routes/safe/components/Transactions/TxList/ThresholdWarning.tsx
Outdated
Show resolved
Hide resolved
schmanu
reviewed
May 6, 2022
schmanu
reviewed
May 6, 2022
schmanu
approved these changes
May 6, 2022
|
Looking sharp! Moving the 2 related issues to QA done ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3471 and #3723
How this PR fixes it
A new
AlertTooltipWarningcomponent was created and added to (unexpected) delegate calls, as well as confirmation policy changes.Confirmation policy change descriptions have also been adjusted.
Note: this does not include a link to an article regarding delegate calls.
How to test it
Screenshots
(Unexpected) delegate call:
rin:0x73a7AA145338587f7aB7f63c06d187C85dF4727e/transactions/multisig_0x73a7AA145338587f7aB7f63c06d187C85dF4727e_0xba28109747222d6cfb7f0fb75f03d49957e343674bc116162b038e244dbcc6d6Threshold alteration: (
rin:0xAb5e3288640396C3988af5a820510682f3C58adF/transactions/multisig_0xAb5e3288640396C3988af5a820510682f3C58adF_0x3a2f4ef3358d80bb776efabc9e29757441fe2fdba2dc2ead688ee9146a280def)