‼️ change session passing from cookie to query

BREAKING CHANGE: socket.io-client\s `extraHeaders` option **works only on nodejs**
socketio/socket.io-client#1159

Author: 59naga

README.md

@@ -43,8 +43,8 @@ io.use(ioMiddleware);
 server.listen(() => {
   const { port } = server.address();
   const client = createIoClient(`http://localhost:${port}`, {
-    extraHeaders: {
-      Cookie: "session=" //+await firebaseAdmin.auth().createSessionCookie(idToken)
+    query: {
+      session: ""//await firebaseAdmin.auth().createSessionCookie(idToken)
     }
   });
   client.on("connect", error => {

index.mjs

@@ -1,14 +1,10 @@
-import cookie from "cookie";
-
 export default (app, options = {}) => {
   const auth = app.auth();
   const opts = Object.assign({ deny: true, cache: true }, options);
 
   const cache = {};
   const middleware = async (client, next) => {
-    const { session = "" } = cookie.parse(
-      client.handshake.headers.cookie || ""
-    );
+    const { session = "" } = client.handshake.query;
     if (!session && !opts.deny) {
       return next();
     }

package.json

@@ -2,17 +2,18 @@
   "name": "socket.io-middleware-firebase-admin",
   "version": "0.0.1",
   "description": "a socket.io middleware firebaseAdmin.verifySessionCookie",
-  "files": ["index.js", "index.mjs"],
+  "files": [
+    "index.js",
+    "index.mjs"
+  ],
   "scripts": {
     "start": "abby format, test --watch \"*.mjs\"",
     "test": "node --experimental-modules test.mjs",
     "format": "prettier \"*.mjs\" --write",
     "build": "babel index.mjs --out-file index.js",
     "postversion": "git push --follow-tags && conventional-github-releaser -p atom"
   },
-  "dependencies": {
-    "cookie": "^0.3.1"
-  },
+  "dependencies": {},
   "devDependencies": {
     "@babel/cli": "^7.0.0-rc.1",
     "@babel/core": "^7.0.0-rc.1",

test-helpers.mjs

@@ -45,13 +45,9 @@ export const createIoServerAsync = ioMiddleware => {
   });
 };
 
-export const createIoClientAsync = (port, cookie) => {
+export const createIoClientAsync = (port, query) => {
   return new Promise((resolve, reject) => {
-    const client = createIoClient(`http://localhost:${port}`, {
-      extraHeaders: {
-        Cookie: cookie
-      }
-    });
+    const client = createIoClient(`http://localhost:${port}`, { query });
     client.on("connect", () => {
       resolve(client);
     });

test.mjs

@@ -27,7 +27,7 @@ spec.after(async () => {
 });
 
 spec("should deny unauthorized user using deny mode(default)", async () => {
-  const error = await rejects(createIoClientAsync(port, "session="));
+  const error = await rejects(createIoClientAsync(port));
   const expectMessage = "Decoding Firebase session cookie failed";
   strictEqual(error.message.slice(0, expectMessage.length), expectMessage);
 });
@@ -45,7 +45,7 @@ spec(
       });
     });
 
-    const client = await createIoClientAsync(port, `session=${session}`);
+    const client = await createIoClientAsync(port, { session });
     await new Promise(async resolve => {
       client.emit("claims", claims => {
         strictEqual(claims.email, "i59naga@icloud.com");

yarn.lock

@@ -904,7 +904,7 @@ convert-source-map@^1.1.0:
   version "1.5.1"
   resolved "https://registry.yarnpkg.com/convert-source-map/-/convert-source-map-1.5.1.tgz#b8278097b9bc229365de5c62cf5fcaed8b5599e5"
 
-cookie@0.3.1, cookie@^0.3.1:
+cookie@0.3.1:
   version "0.3.1"
   resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.3.1.tgz#e7e0a1f9ef43b4c8ba925c5c5a96e806d16873bb"
 
@@ -1043,8 +1043,8 @@ eastasianwidth@^0.2.0:
   resolved "https://registry.yarnpkg.com/eastasianwidth/-/eastasianwidth-0.2.0.tgz#696ce2ec0aa0e6ea93a397ffcf24aa7840c827cb"
 
 eastern@^0.1.0:
-  version "0.1.0"
-  resolved "https://registry.yarnpkg.com/eastern/-/eastern-0.1.0.tgz#5018052e0333f5c351499ef42589fb999a558359"
+  version "0.1.1"
+  resolved "https://registry.yarnpkg.com/eastern/-/eastern-0.1.1.tgz#5d3f87714a139eda0588edcbd897903ded92eaa8"
   dependencies:
     chalk "^2.4.1"
     exit-hook "^2.0.0"