Skip to content

Commit 045a247

Browse files
committed
‼️ change first argument obj to appInstance
1 parent c12c5f4 commit 045a247

File tree

4 files changed

+16
-18
lines changed

4 files changed

+16
-18
lines changed

README.md

+5-4
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ yarn add socket.io-middleware-firebase-admin
2121
API
2222
---
2323

24-
## createIoMiddlewareFirebaseAdmin({ credential }, (options = {})): middleware
25-
26-
[initialize "Firebase Admin SDK" using `credential`](https://firebase.google.com/docs/admin/setup)
24+
## createIoMiddlewareFirebaseAdmin(app, (options = {})): middleware
2725

2826
```js
2927
import { createServer } from "http";
@@ -35,7 +33,10 @@ import credential from "./.credential";
3533

3634
const server = createServer();
3735
const io = createIoServer(server);
38-
const ioMiddleware = createIoMiddlewareFirebaseAdmin({ credential });
36+
const app = firebaseAdmin.initializeApp({
37+
credential: firebaseAdmin.credential.cert(credential)
38+
});
39+
const ioMiddleware = createIoMiddlewareFirebaseAdmin(app);
3940

4041
io.use(ioMiddleware);
4142

index.mjs

+2-9
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
1-
import firebaseAdmin from "firebase-admin";
21
import cookie from "cookie";
32

4-
export default ({ credential }, options = {}) => {
5-
const app = firebaseAdmin.initializeApp({
6-
credential: firebaseAdmin.credential.cert(credential)
7-
});
8-
const auth = firebaseAdmin.auth();
3+
export default (app, options = {}) => {
4+
const auth = app.auth();
95
const opts = Object.assign({ deny: true, cache: true }, options);
106

117
const cache = {};
@@ -41,9 +37,6 @@ export default ({ credential }, options = {}) => {
4137
middleware.deleteCache = key => {
4238
delete cache[key];
4339
};
44-
middleware.firebaseAdminClose = () => {
45-
app.delete();
46-
};
4740

4841
middleware.extra = {
4942
verifyCustomTokenUrl:

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
"postversion": "git push --follow-tags && conventional-github-releaser -p atom"
1111
},
1212
"dependencies": {
13-
"cookie": "^0.3.1",
14-
"firebase-admin": "^6.0.0"
13+
"cookie": "^0.3.1"
1514
},
1615
"devDependencies": {
1716
"@babel/cli": "^7.0.0-rc.1",
@@ -22,6 +21,7 @@
2221
"babel-plugin-add-module-exports": "^0.3.3",
2322
"bluebird": "^3.5.1",
2423
"eastern": "^0.1.0",
24+
"firebase-admin": "^6.0.0",
2525
"prettier": "^1.14.2",
2626
"request": "^2.88.0",
2727
"server-destroy": "^1.0.1",

test.mjs

+7-3
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,21 @@ import {
88
createIoClientAsync,
99
createSession
1010
} from "./test-helpers";
11+
import firebaseAdmin from "firebase-admin";
1112
import createFirebaseAdminMiddlware from "./";
1213
import credential from "./.credential";
1314

14-
let middleware, server, port;
15+
let app, middleware, server, port;
1516
spec.before(async () => {
16-
middleware = createFirebaseAdminMiddlware({ credential });
17+
app = firebaseAdmin.initializeApp({
18+
credential: firebaseAdmin.credential.cert(credential)
19+
});
20+
middleware = createFirebaseAdminMiddlware(app);
1721
server = await createIoServerAsync(middleware);
1822
port = server.address().port;
1923
});
2024
spec.after(async () => {
21-
middleware.firebaseAdminClose();
25+
app.delete();
2226
server.destroy();
2327
});
2428

0 commit comments

Comments
 (0)