Keep it php 5.6 compatible

Author: AlexKarpan

AspectPropertyValue.php

@@ -32,9 +32,9 @@
 */
 class AspectPropertyValue
 {
-    private $value;
-    private $noValueMessage;
-    public $hasValue;
+    private $_value;
+    public $noValueMessage = null;
+    public $hasValue = false;
 
     /**
     * Constructor for AspectPropertyValue
@@ -64,12 +64,18 @@ public function __get($key)
     {
         if ($key === "value") {
             if ($this->hasValue) {
-                return $this->value;
-            } else {
-                throw new \Exception(
-                    empty($this->noValueMessage) ? '' : $this->noValueMessage
-                );
+                return $this->_value;
+            } else if (!empty($this->noValueMessage)) {
+                throw new \Exception($this->noValueMessage);
             }
         }
     }
+
+    public function __set($key, $value)
+    {
+        if ($key === "value") {
+            $this->_value = $value;
+            $this->hasValue = true;
+        }
+    }
 }

BasicListEvidenceKeyFilter.php

@@ -49,15 +49,13 @@ public function __construct($list)
     */
     public function filterEvidenceKey($key)
     {
-        $keep = false;
-
         foreach ($this->list as $evidenceKey) {
             if (strtolower($key) === strtolower($evidenceKey)) {
-                $keep = true;
+                return true;
             }
         }
 
-        return $keep;
+        return false;
     }
 
     /**

ElementDataDictionary.php

@@ -30,7 +30,7 @@
 **/
 class ElementDataDictionary extends ElementData
 {
-    private $contents;
+    public $contents;
 
     /**
     * Constructor for element data dictionary

EvidenceKeyFilter.php

@@ -32,7 +32,7 @@
 */
 class EvidenceKeyFilter
 {
-    public $filterEvidenceKey;
+    private $_filterEvidenceKey = null;
 
     /**
     * filterevidence from an object
@@ -59,6 +59,17 @@ public function filterEvidence($evidenceKeyObject)
     */
     public function filterEvidenceKey($key)
     {
+        if ($this->_filterEvidenceKey) {
+            return call_user_func($this->_filterEvidenceKey, $key);
+        }
+
         return true;
     }
+
+    public function __set($name, $value)
+    {
+        if ($name === 'filterEvidenceKey') {
+            $this->_filterEvidenceKey = $value;
+        }
+    }
 }

FlowElement.php

@@ -32,18 +32,11 @@
 **/
 class FlowElement
 {
-    public $pipelines;
-
-    public function __construct()
-    {
-
-        // List of Pipelines the FlowElement has been added to
-        $this->pipelines = [];
-    }
-
     public $dataKey;
     public $properties = [];
-    
+    // List of Pipelines the FlowElement has been added to
+    public $pipelines = [];
+
     /**
      * General wrapper function that calls a FlowElement's processInternal method
      * @param FlowData

JavascriptBuilder.php

@@ -36,8 +36,8 @@
  */
 class JavascriptBuilderElement extends FlowElement
 {
-    private $settings;
-    private $minify;
+    public $settings;
+    public $minify;
 
     public function __construct($settings = array())
     {

Pipeline.php

@@ -36,7 +36,7 @@ class Pipeline
     public $logger;
     public $metaDataStore;
     public $suppressProcessExceptions;
-    private $propertyDatabase;
+    public $propertyDatabase;
 
     /**
      * Pipeline constructor

PipelineBuilder.php

@@ -31,9 +31,9 @@
 class PipelineBuilder
 {
     public $pipelines;
-    private $addJavaScriptBuilder;
-    private $javascriptBuilderSettings;
-    private $useSetHeaderProperties;
+    public $addJavaScriptBuilder;
+    public $javascriptBuilderSettings;
+    public $useSetHeaderProperties;
 
     public function __construct($settings = array())
     {

SetHeaderElement.php

@@ -153,14 +153,14 @@ public function getPropertyValue($flowData, $elementKey, $propertyKey){
 
 		$propertyKey = strtolower($propertyKey);
 		try {
-            $property = $elementData->$propertyKey;
+            $property = isset($elementData->$propertyKey) ? $elementData->$propertyKey : null;
 		}
         catch (Exception $e) {
 			echo sprintf(Messages::PROPERTY_NOT_FOUND, $propertyKey, $elementKey);
 			return "";
 		}
 
-		if($property->hasValue && !in_array($property->value, ["Unknown", "noValue"])){
+		if($property && $property->hasValue && !in_array($property->value, ["Unknown", "noValue"])){
 			$value = $property->value;
 		}
         else{

tests/JavaScriptBundlerTests.php

@@ -67,6 +67,8 @@ public function processInternal($FlowData)
 
 class TestPipeline
 {
+    public $Pipeline;
+
     public function __construct($minify = NULL)
     {
         if (is_null($minify)) {