Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections API doesn't return photos that are still being rendered #83

Open
Mossop opened this issue Jun 17, 2014 · 0 comments
Open

Collections API doesn't return photos that are still being rendered #83

Mossop opened this issue Jun 17, 2014 · 0 comments

Comments

@Mossop
Copy link

Mossop commented Jun 17, 2014

Both PUT collections/:id and GET collections return a list of photos in the collection however it seems to not include photos that have just been uploaded and are still being rendered (show the throbber on the 500px website).

This breaks certain operations in the official Lightroom plugin where attempting to remove photos from a collection at the same time as uploading new photos will not work correctly. The following steps happen:

GET collections returns the current photos in the collection
New photos are uploaded and then PUT collections/:id is called to add each one to the collection
GET collections is called again to remove photos from the collection but the result doesn't yet include the new photos added so when PUT collection/:id is called those photos end up being dropped from the collection.

Ideally the API should include even the still rendering photos in the lists however an alternative way to fix this problem which I think would be a nice addition to the API is an API call to add photos to a collection and an API call to remove photos from a collection. This would save the need to get the list of photos in the collection first reducing API traffic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant