Skip to content

Commit b7b87b2

Browse files
author
Huang Wei
committed
fix
1 parent 4ade1d5 commit b7b87b2

File tree

1 file changed

+28
-20
lines changed

1 file changed

+28
-20
lines changed

src/cmd/sql_cmd_test.cc

Lines changed: 28 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1628,19 +1628,18 @@ TEST_P(DBSDKTest, DeployLongWindows) {
16281628
rs = sr->ExecuteSQL("", result_sql, &status);
16291629
ASSERT_EQ(3, rs->Size());
16301630

1631-
std::string msg;
1632-
auto ok = sr->ExecuteDDL(openmldb::nameserver::PRE_AGG_DB, "drop table pre_test2_demo1_w1_sum_c4;", &status);
1633-
ASSERT_TRUE(ok);
1634-
ok = sr->ExecuteDDL(openmldb::nameserver::PRE_AGG_DB, "drop table pre_test2_demo1_w2_max_c5;", &status);
1635-
ASSERT_TRUE(ok);
1636-
ok = sr->ExecuteDDL(openmldb::nameserver::PRE_AGG_DB, "drop table pre_test2_demo3_w1_count_where_c4_c3;", &status);
1637-
ASSERT_TRUE(ok);
1638-
ASSERT_FALSE(cs->GetNsClient()->DropTable("test2", "trans", msg));
1639-
ASSERT_TRUE(cs->GetNsClient()->DropProcedure("test2", "demo1", msg));
1640-
ASSERT_TRUE(cs->GetNsClient()->DropProcedure("test2", "demo2", msg));
1641-
ASSERT_TRUE(cs->GetNsClient()->DropProcedure("test2", "demo3", msg));
1642-
ASSERT_TRUE(cs->GetNsClient()->DropTable("test2", "trans", msg));
1643-
ASSERT_TRUE(cs->GetNsClient()->DropDatabase("test2", msg));
1631+
// drop deployment
1632+
sr->ExecuteSQL("test2", "drop deployment demo1;", &status);
1633+
ASSERT_TRUE(status.IsOK()) << status.ToString();
1634+
rs = sr->ExecuteSQL("test2", "drop deployment demo2;", &status);
1635+
ASSERT_TRUE(status.IsOK()) << status.ToString();
1636+
rs = sr->ExecuteSQL("test2", "drop deployment demo3;", &status);
1637+
ASSERT_TRUE(status.IsOK()) << status.ToString();
1638+
1639+
sr->ExecuteSQL("test2", "drop table trans", &status);
1640+
ASSERT_TRUE(status.IsOK()) << status.ToString();
1641+
sr->ExecuteSQL("drop database test2;", &status);
1642+
ASSERT_TRUE(status.IsOK()) << status.ToString();
16441643
}
16451644

16461645
void CreateDBTableForLongWindow(const std::string& base_db, const std::string& base_table) {
@@ -3391,26 +3390,35 @@ TEST_P(DBSDKTest, LongWindowsCleanup) {
33913390
" max(c5) over w2 as w2_max_c5 FROM trans"
33923391
" WINDOW w1 AS (PARTITION BY trans.c1 ORDER BY trans.c7 ROWS BETWEEN 2 PRECEDING AND CURRENT ROW),"
33933392
" w2 AS (PARTITION BY trans.c1 ORDER BY trans.c4 ROWS BETWEEN 3 PRECEDING AND CURRENT ROW);";
3393+
33943394
for (int i = 0; i < 10; i++) {
33953395
HandleSQL("create database test2;");
33963396
HandleSQL("use test2;");
33973397
HandleSQL(create_sql);
3398+
LOG(INFO) << "before deploy " << i;
3399+
HandleSQL("select * from __INTERNAL_DB.PRE_AGG_META_INFO;");
33983400
sr->ExecuteSQL(deploy_sql, &status);
33993401
ASSERT_TRUE(status.IsOK());
3402+
absl::SleepFor(absl::Seconds(3));
3403+
LOG(INFO) << "after deploy " << i;
3404+
HandleSQL("select * from __INTERNAL_DB.PRE_AGG_META_INFO;");
34003405
std::string msg;
34013406
std::string result_sql = "select * from __INTERNAL_DB.PRE_AGG_META_INFO;";
34023407
auto rs = sr->ExecuteSQL("", result_sql, &status);
3408+
ASSERT_TRUE(status.IsOK()) << status.ToString();
34033409
ASSERT_EQ(2, rs->Size());
3404-
auto ok = sr->ExecuteDDL(openmldb::nameserver::PRE_AGG_DB, "drop table pre_test2_demo1_w1_sum_c4;", &status);
3405-
ASSERT_TRUE(ok);
3406-
ok = sr->ExecuteDDL(openmldb::nameserver::PRE_AGG_DB, "drop table pre_test2_demo1_w2_max_c5;", &status);
3407-
ASSERT_TRUE(ok);
3410+
sr->ExecuteSQL("test2", "drop table trans;", &status);
3411+
ASSERT_FALSE(status.IsOK());
3412+
sr->ExecuteSQL("drop procedure demo1;", &status);
3413+
ASSERT_TRUE(status.IsOK()) << status.ToString();
3414+
sr->ExecuteSQL("test2", "drop table trans;", &status);
3415+
ASSERT_TRUE(status.IsOK()) << status.ToString();
3416+
34083417
result_sql = "select * from __INTERNAL_DB.PRE_AGG_META_INFO;";
3418+
HandleSQL(result_sql);
34093419
rs = sr->ExecuteSQL("", result_sql, &status);
3420+
ASSERT_TRUE(status.IsOK()) << status.ToString();
34103421
ASSERT_EQ(0, rs->Size());
3411-
ASSERT_FALSE(cs->GetNsClient()->DropTable("test2", "trans", msg));
3412-
ASSERT_TRUE(cs->GetNsClient()->DropProcedure("test2", "demo1", msg)) << msg;
3413-
ASSERT_TRUE(cs->GetNsClient()->DropTable("test2", "trans", msg)) << msg;
34143422
// helpful for debug
34153423
HandleSQL("show tables;");
34163424
HandleSQL("show deployments;");

0 commit comments

Comments
 (0)