Wait for Auth to be initialized

Author: ClementPasteau

newIDE/app/src/Profile/AuthenticatedUserProvider.js

@@ -152,6 +152,11 @@ export default class AuthenticatedUserProvider extends React.Component<
   >(listUserCloudProjects);
 
   async componentDidMount() {
+    // Wait for Firebase to complete its initial auth check before doing anything.
+    // This prevents a race condition where we check auth state before Firebase
+    // has finished initializing, causing us to incorrectly think the user is logged out.
+    await this.props.authentication.waitForInitialAuthCheck();
+
     this._initializeAuthenticatedUser();
 
     // Those callbacks are added a bit too late (after the authentication `hasAuthChanged` has already been triggered)
@@ -185,8 +190,9 @@ export default class AuthenticatedUserProvider extends React.Component<
       }
     });
 
-    // At startup, if the provider has mounted too late and the user is already logged in with Firebase,
-    // we fetch the user profile.
+    // At startup, check if the user is already logged in with Firebase.
+    // Note: We can now safely check this synchronously because we've waited for
+    // Firebase's initial auth check to complete above.
     if (this.props.authentication.getFirebaseUserSync()) {
       // The user is logged already: fetch its user profile (because the "user update"
       // won't trigger, as registered too late).

newIDE/app/src/Utils/GDevelopServices/Authentication.js

@@ -125,11 +125,28 @@ export default class Authentication {
   _onUserLogoutCallbacks: Array<() => void | Promise<void>> = [];
   _onUserUpdateCallbacks: Array<() => void | Promise<void>> = [];
   loginProvider: ?LoginProvider;
+  _initialAuthCheckPromise: Promise<void>;
 
   constructor() {
     const app = initializeApp(GDevelopFirebaseConfig);
     this.auth = getAuth(app);
+
+    // Create a promise that resolves when Firebase completes its initial auth check.
+    // This prevents race conditions where components check auth state before Firebase
+    // has finished initializing.
+    let resolveInitialCheck;
+    this._initialAuthCheckPromise = new Promise(resolve => {
+      resolveInitialCheck = resolve;
+    });
+
+    let isFirstCall = true;
     onAuthStateChanged(this.auth, user => {
+      if (isFirstCall) {
+        // First call - Firebase has completed initial auth check
+        isFirstCall = false;
+        resolveInitialCheck();
+      }
+
       if (user) {
         // User has logged in or changed.
         this._onUserUpdateCallbacks.forEach(cb => cb());
@@ -530,4 +547,8 @@ export default class Authentication {
   isAuthenticated = (): boolean => {
     return !!this.auth.currentUser;
   };
+
+  waitForInitialAuthCheck = (): Promise<void> => {
+    return this._initialAuthCheckPromise;
+  };
 }