New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS Review: error in model_viewer description #327

Closed

wcjochem opened this issue Aug 29, 2024 · 0 comments · Fixed by #331

Assignees

Labels

JOSS

wcjochem commented Aug 29, 2024 •

edited

Loading

Describe the bug
The documentation for fdmr::model_viewer is incorrect and is a duplicate of fdmr::mesh_builder

Expected behavior
Updated description of the function to match its use.

To Reproduce
Check: https://github.com/4DModeller/fdmr/blob/main/R/shiny_modelviewer.R#L298

openjournals/joss-reviews#7047

mnky9800n assigned aabelean

mnky9800n added the JOSS label

aabelean linked a pull request

that will close this issue

Error in model_viewer description #331

Merged

3 tasks

aabelean mentioned this issue

Error in model_viewer description #331

Merged

3 tasks

mnky9800n closed this as completed in #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment