Skip to content

Conversation

@manon-pilaud
Copy link
Contributor

No description provided.

@manon-pilaud manon-pilaud requested a review from jquense July 2, 2020 17:07
];

const DEFAULT_BROWSERS = [
'ie >= 11',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we definitely don't want any IE support by default?

don't all of our apps set custom browser lists anyway?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apps usually (should) set a default via a browserslist config file, yeah. I think that generally all of our libraries should default to a target that balances minimal compiled output and browser support. Including IE, though makes most of bugfixes useless since there is very little that can be fixed without down-leveling.

I think my position here is that libraries should not exclude ie11 support, e.g. should allow further compiling and polyfilling in the app, like we do for the browser support pages. I don't think a default set of browsers that includes ie11 here tho makes that more likely tho. Overall, new syntax can generally be polyfilled/down-leveled, the real issues are usually around subtle CSS differences or engine quirks, things that you don't uncover unless you are actually testing in IE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants