feat: Add support for filtering encrypted field by list of values #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10309403851Details
💛 - Coveralls |
SteveKekacs
changed the title
franky47
requested changes
Aug 12, 2024
| @@ -67,7 +67,7 @@ export function encryptOnWrite<Models extends string, Actions extends string>( | |||
| models, | |||
| function encryptFieldValue({ | |||
| fieldConfig, | |||
| value: clearText, | |||
| value: unHashedValue, | |||
There was a problem hiding this comment.
suggestion: Keep the original clearText name, as the value is not only used for hashing, but also for encryption in most (writing) cases.
src/encryption.ts
Outdated
Comment on lines
88
to
89
| if (typeof unHashedValue === 'object') { | ||
| hash = (unHashedValue as string[]).map((value) => hashString(value, fieldConfigHash)); |
There was a problem hiding this comment.
suggestion: Use the Array.isArray function, to make the intent clearer. It also removes the need for the as string[] type casting.
src/encryption.ts
Outdated
|
|
||
| // Encrypting list values is not yet supported | ||
| if (typeof unHashedValue !== 'string') { | ||
| return; |
There was a problem hiding this comment.
suggestion: Could we add a log point to this code path, for debugging? It's unlikely we'll hit it with Prisma's current API AFAIK, but it would make it easier to catch issues in the future.
| ( | ||
| // Used for where: { field: in: []} queries | ||
| typeof (node as any)?.[specialSubField] === 'string' || | ||
| typeof (node as any)?.[specialSubField] === 'object' |
There was a problem hiding this comment.
suggestion: Same test here, using Array.isArray.
- Apply Prettier formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a stab at implementing a fix for #119.