Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So-called "unnecessary header inclusion" #469

Open
h-akbas opened this issue Dec 10, 2023 · 0 comments
Open

So-called "unnecessary header inclusion" #469

h-akbas opened this issue Dec 10, 2023 · 0 comments
Labels
question Further information is requested

Comments

@h-akbas
Copy link

h-akbas commented Dec 10, 2023

Students at 42 Kocaeli Campus are failed due to unnecessary header inclusion because they include header libraries (such as "unistd.h") because not all C files are using this library (in fact only one of them is using read()) so only the .c file that uses that function should include the library and it's forbidden to use elsewhere.

My question is that while we arguably benefit from slightly faster compile time, it leads to bad design practices in my humble opinion. Page 10 of Norm v4 suggests that no unused libraries can be included. The aim of the norm is to create a standard for all 42 schools and (alumni as well) but this kind of harsh evaluations at our campus seem deviant from what happens at other 42 campuses.

Page 10 of the Norm file doesn't specify openly as to what to do in such inclusion. Additionally, from what can be observed from the contributions from other campuses, no one else at other campuses conforms to this rule even if it exists.

@h-akbas h-akbas closed this as completed Feb 1, 2024
@h-akbas h-akbas reopened this Feb 1, 2024
@Asandolo Asandolo added the question Further information is requested label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants