Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setDialogSize is useless #39

Open
Anrolosia opened this issue Oct 14, 2014 · 0 comments
Open

setDialogSize is useless #39

Anrolosia opened this issue Oct 14, 2014 · 0 comments

Comments

@Anrolosia
Copy link

Hi !

In SocialAuthAdapter.java:770, your method setDialogSize is useless since you set in SocialAuthDialog.java DIMENSIONS_DIFF_LANDSCAPE and DIMENSIONS_DIFF_PORTRAIT in the declaration scope

"width" and "height" are overridden by method, but they're only used to define both previous variables.

Did I miss something ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Anrolosia