Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer throws NullPointerException on Model Import #103

Closed
daniel-de opened this issue Sep 30, 2019 · 5 comments
Closed

Importer throws NullPointerException on Model Import #103

daniel-de opened this issue Sep 30, 2019 · 5 comments
Assignees

Comments

@daniel-de
Copy link

Hi,

trying to import a file with Version 4.2.2, which is imported successfully with Version 3.3.2 now throws a NullPointerException after xAL address element:

[16:05:38 ERROR] core:Address (unknown gml:id): Failed to interpret xAL address element.
[16:05:38 ERROR] An error occurred: null
[16:05:38 ERROR] Aborting due to an unexpected java.lang.NullPointerException error.

I could share a small data set for debugging if necessary...

kind regards,
Daniel

@clausnagel
Copy link
Member

Hi Daniel, a test dataset would indeed be very helpful.

@daniel-de
Copy link
Author

daniel-de commented Sep 30, 2019

Hi Claus,

I'm not allowed to post the data here.
Sending them via email?

@clausnagel
Copy link
Member

clausnagel commented Sep 30, 2019

Sure. You can use the email from my GitHub profile: cnagel@virtualcitysystems.de

You can strip down the content as much as possible. In the end, a <Building> with the <address> property that causes the issue is already sufficient. Delete everything else if you want.

@clausnagel clausnagel added the bug label Sep 30, 2019
@clausnagel clausnagel self-assigned this Sep 30, 2019
@clausnagel
Copy link
Member

clausnagel commented Sep 30, 2019

Your dataset violates the CityGML schema. For two addresses, the <xAL:AddressDetails> element is given as direct child element of <core:Address>. However, there must be a <core:xalAddress> property element inbetween (check lines 220340 and 220364). You can easily validate your CityGML input datasets by clicking the "Just validate" button on the "Import" tab. Interestingly, all other address elements in your dataset are correct.

Nevertheless, there was also a bug which caused the import process to fail for invalid address elements. I fixed this bug (3825ebb). Simply build a new version of the importer from the master branch to benefit from the bugfix.

@daniel-de
Copy link
Author

Thanks a lot, dataset is importing now. The model was exported from proprietary software. Trying to inform the manufacturer about the bug...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants