Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default google 3d tiles not shown in scenegraph after setting location #770

Closed
kfarr opened this issue Aug 17, 2024 · 2 comments
Closed
Assignees

Comments

@kfarr
Copy link
Collaborator

kfarr commented Aug 17, 2024

after adding 3dtiles, somehow we needs to fire another entitychanged or whatever scenegraph update event needed

the tiles are added how? i think in the modal maybe after the update button is pressed?

@vincentfretin
Copy link
Collaborator

I'm not sure if this is this one, but the onSaveHandler in GeoModal here

const onSaveHandler = () => {
const latitude = markerPosition.lat;
const longitude = markerPosition.lng;
const geoLayer = document.getElementById('reference-layers');
geoLayer.setAttribute(
'street-geo',
`latitude: ${latitude}; longitude: ${longitude}; ellipsoidalHeight: ${elevation}; orthometricHeight: ${heightData?.orthometricHeight}; geoidHeight: ${heightData?.geoidHeight}`
);
onClose();
};

should definitely be rewritten to use EntityUpdateCommand similar to https://github.com/3DStreet/3dstreet/pull/789/files#diff-a70d189aca39070b7c4bd36206c8df559633374a33865caf6616323d1e403e4cR49 after the following PR is merged.

@vincentfretin
Copy link
Collaborator

I did the above change in #789 but that was not the issue. I did fix it in 6990401 though.

@vincentfretin vincentfretin self-assigned this Aug 28, 2024
@kfarr kfarr closed this as completed in 6990401 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants