Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New scene title is not saved in the JSON file #553

Closed
Algorush opened this issue Jun 4, 2024 · 2 comments
Closed

New scene title is not saved in the JSON file #553

Algorush opened this issue Jun 4, 2024 · 2 comments
Assignees
@Algorush

Comments

@Algorush
Copy link
Collaborator

Algorush commented Jun 4, 2024

There's always title='scene'
@Algorush Algorush self-assigned this Jun 4, 2024
@kfarr
Copy link
Collaborator

kfarr commented Jun 6, 2024

@Algorush thanks I tested and reproduced, however this is just for downloaded 3dstreet.json files and not cloud, the cloud title and rename saving seems to work as expected.

Here seems to be the offending line:
https://github.com/3DStreet/3dstreet/blob/main/src/json-utils_1.1.js#L58

@Algorush Algorush mentioned this issue Jun 8, 2024
Merged
@kfarr
Copy link
Collaborator

kfarr commented Jun 10, 2024

fixed with #573

@kfarr kfarr closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Algorush Algorush

Labels
None yet
Projects
3DStreet Dev Tracking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfarr @Algorush