From 2af966e699f137e9d609655b67a23b466ba0742e Mon Sep 17 00:00:00 2001 From: CharlesCheung <61726649+CharlesCheung96@users.noreply.github.com> Date: Mon, 7 Aug 2023 11:02:41 +0800 Subject: [PATCH] processor(ticdc): do not ignore ErrRedoWriterStopped (#9451) close pingcap/tiflow#9378 --- cdc/processor/processor.go | 1 - cdc/processor/processor_test.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cdc/processor/processor.go b/cdc/processor/processor.go index 9581a75fff3..d27155f54d9 100644 --- a/cdc/processor/processor.go +++ b/cdc/processor/processor.go @@ -424,7 +424,6 @@ func newProcessor( var processorIgnorableError = []*errors.Error{ cerror.ErrAdminStopProcessor, cerror.ErrReactorFinished, - cerror.ErrRedoWriterStopped, } // isProcessorIgnorableError returns true if the error means the processor exits diff --git a/cdc/processor/processor_test.go b/cdc/processor/processor_test.go index ace1ef90008..4fcc82d44cd 100644 --- a/cdc/processor/processor_test.go +++ b/cdc/processor/processor_test.go @@ -632,7 +632,7 @@ func TestIgnorableError(t *testing.T) { {nil, true}, {cerror.ErrAdminStopProcessor.GenWithStackByArgs(), true}, {cerror.ErrReactorFinished.GenWithStackByArgs(), true}, - {cerror.ErrRedoWriterStopped.GenWithStackByArgs(), true}, + {cerror.ErrRedoWriterStopped.GenWithStackByArgs(), false}, {errors.Trace(context.Canceled), true}, {cerror.ErrProcessorTableNotFound.GenWithStackByArgs(), false}, {errors.New("test error"), false},