Optimised imports, minor grammar fixes - solver.py #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arthurauffray
commented
Jun 12, 2024
arthurauffray
commented
- Fixed imports to only import required items instead of the entire module (faster execution, reduced resource usage)
- One or two grammar changes
- Removed extra blank line in "if name main" convention
- Fixed imports to only import required items instead of the entire module (faster execution, reduced resource usage) - One or two grammar changes - Removed extra blank line in "if name main" convention
|
@kratzky This PR has changed imports for specific modules, adjusted method calls in the code, which generally optimizes the code, and also fixed several grammatical errors in method descriptions. I checked that the tests pass with this code. You can merge |
|
The same as #91 it's about the code style, not the optimisation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.