From 9be04f02356b1bb6ebeb8048e4d6449f5d3f8bee Mon Sep 17 00:00:00 2001 From: maniscalco Date: Thu, 2 Oct 2014 11:35:33 -0700 Subject: [PATCH] Improve MessageLoop's comments. Remove incorrect mention of RefCountedThreadSafe from DeleteSoon's comment. Replace mention of PostDelayedTask with ReleaseSoon in ReleaseSoon's comment. BUG= Review URL: https://codereview.chromium.org/615693002 Cr-Commit-Position: refs/heads/master@{#297870} --- base/message_loop/message_loop.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/base/message_loop/message_loop.h b/base/message_loop/message_loop.h index 3cec37e1a0b8..c9a9185d35de 100644 --- a/base/message_loop/message_loop.h +++ b/base/message_loop/message_loop.h @@ -194,9 +194,7 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate { // good). // // NOTE: This method may be called on any thread. The object will be deleted - // on the thread that executes MessageLoop::Run(). If this is not the same - // as the thread that calls PostDelayedTask(FROM_HERE, ), then T MUST inherit - // from RefCountedThreadSafe! + // on the thread that executes MessageLoop::Run(). template void DeleteSoon(const tracked_objects::Location& from_here, const T* object) { base::subtle::DeleteHelperInternal::DeleteViaSequencedTaskRunner( @@ -223,7 +221,7 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate { // NOTE: This method may be called on any thread. The object will be // released (and thus possibly deleted) on the thread that executes // MessageLoop::Run(). If this is not the same as the thread that calls - // PostDelayedTask(FROM_HERE, ), then T MUST inherit from + // ReleaseSoon(FROM_HERE, ), then T MUST inherit from // RefCountedThreadSafe! template void ReleaseSoon(const tracked_objects::Location& from_here,