This repository was archived by the owner on Oct 14, 2025. It is now read-only.
fix(engine): npc renderer to remove permanent nids properly #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pazaz
added a commit
that referenced
this pull request
Nov 16, 2024
We've reached 1000 PRs! Sincerest appreciation to all contributors that are working on this. ## Content Changes ### Features * #968 * #991 ### Fixes * #989 * #990 * #998 * #1000 * #1003 ## Engine Changes ### Features * #992 * #994 * #996 * #1001 * Automatic image quantization. We use the original packed sprites, so this code only runs when custom images are added to the data folder. ### Fixes * #993 * #995 * #1002 * Jagfile decompression could fail using standard libbz2 due to a packing oversight. The client was unaffected. * Removed quotes from constants referenced in scripts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving it to the appropriate spot since it was written before I wrote the
npc.nid = -1;&npc.uid = -1;.