Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Added extra logic to safeguard devs from resurrecting stale Locs #1467

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

mark-b5
Copy link
Contributor

@mark-b5 mark-b5 commented Mar 15, 2025

Very small fix that should have been addressed in the last PR

[debugproc,loc_del_change]
if (p_finduid(uid) = true) {
    p_telejump(0_37_55_32_30);
    p_delay(0);
    loc_add(0_37_55_32_30, loc_1276, 0, centrepiece_straight, 10);
    p_delay(0);
    loc_del(100);
    p_delay(0);
    loc_change(loc_2732, 10);
}

Adding a static loc, deleting it, and then changing it would bring it back to life before this PR. This is an issue because a dynamic loc gets removed from the Zone when deleting (unlike a static Loc). Now, the loc_change just gets discarded via an early return 🤷

@Pazaz Pazaz merged commit 1cc94b6 into 2004Scape:main Mar 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants