fix(poison): Reworked player poison implementation #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucwousin
reviewed
Mar 12, 2025
| if (%poison = 0) { | ||
| mes("You have been poisoned!"); | ||
| } | ||
| settimer(poison, 30); | ||
| %poison = $severity; |
There was a problem hiding this comment.
I think this should be %poison = max(%poison, $severity)
|
Also updated each call to settimer(poison,30) to first check that the poison timer isn't already active |
|
Fixed inequality mistake, removed antipoison logout/login procs, added proc for setting poison timer |
|
fixed a few syntax errors I made, oopsie |
|
Needs the following
|
|
Fixed the 3 issues raised by b5 above, tested in-game, working as intended |
|
Looks good to me |
pelippper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked poison to work more authentically. Instead of there being 2 variables, %poison and %antipoison, there is just one variable, %poison. This variable is negative if the player has poison immunity, and positive if the player is poisoned. In addition, added poison immunity to strange fruit to work as described by Ash https://archive.is/6SmRo.