-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(poison): Reworked player poison implementation #1455
Conversation
if (%poison = 0) { | ||
mes("You have been poisoned!"); | ||
} | ||
settimer(poison, 30); | ||
%poison = $severity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be %poison = max(%poison, $severity)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks!
Also updated each call to settimer(poison,30) to first check that the poison timer isn't already active |
Fixed inequality mistake, removed antipoison logout/login procs, added proc for setting poison timer |
fixed a few syntax errors I made, oopsie |
Needs the following
|
Fixed the 3 issues raised by b5 above, tested in-game, working as intended |
Looks good to me |
Reworked poison to work more authentically. Instead of there being 2 variables, %poison and %antipoison, there is just one variable, %poison. This variable is negative if the player has poison immunity, and positive if the player is poisoned. In addition, added poison immunity to strange fruit to work as described by Ash https://archive.is/6SmRo.