Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): prevent sql errors on new user login #1447

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

locked-chest
Copy link
Contributor

If a server is ran with Environment.WEBSITE_REGISTRATION disabled, meaning that users can login with any credentials and have an account created, there will be some SQL errors because the response from LoginServer.ts is missing the account_id property. Fix this by returning the primary key inserted for the new account.

image

If a server is ran with `Environment.WEBSITE_REGISTRATION` **disabled**,
meaning that users can login with any credentials and have an account
created, there will be some SQL errors because the response from
LoginServer.ts is missing the `account_id` property. Fix this by
returning the primary key inserted for the new account.
@Pazaz Pazaz merged commit bb3ad95 into 2004Scape:main Mar 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants