fix(content): Fix double flooring for magic defence formula #1442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separation of 'style bonus' and +8 from ~combat_effective_stat, makes it easier to implement void in the future... Restructuring it in a way where style bonuses are applied at the end prevents us from having to -8 to $effective magic and $effective_defence, for effective magic defence.
Our previous effective magic defence would double floor since we used
scale()
. Now the question is, did jagex implement the 30/70 split like:divide(add(multiply(7, $effective_magic), multiply(3, $effective_defence)), 10);
or
add(scale(3, 10, $effective_defence), scale(7, 10, $effective_magic));
My guess is without
scale()
. this will only have very minor differences