Skip to content

Commit dfc780d

Browse files
committed
fix(js): Modified internal request class to use getProperty instead of .property due to an issue wit
Typescript currently generates code for drived class's get method by ignoring the type of the child type completely & directly try and access the property on the parent property, if the property name exposed on the child is different from the parent, then accessing this property in the generated js will obviously give undefined value. TO avoid this, I've explicitly added `getProperty` instead of `get property`
1 parent f09d13a commit dfc780d

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

src/interceptor-request-internal.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,27 @@ import { InterceptorUtils } from './interceptor-utils';
66

77
export class InterceptorRequestInternal extends InterceptorRequest {
88

9-
get shortCircuitAtCurrentStep(): boolean {
9+
getShortCircuitAtCurrentStep(): boolean {
1010
return this._shortCircuitAtCurrentStep;
1111
}
1212

13-
get alsoForceRequestCompletion(): boolean {
13+
getAlsoForceRequestCompletion(): boolean {
1414
return this._alsoForceRequestCompletion;
1515
}
1616

17-
get alreadyShortCircuited(): boolean {
17+
getAlreadyShortCircuited(): boolean {
1818
return this._alreadyShortCircuited;
1919
}
2020

21-
get shortCircuitTriggeredBy(): number {
21+
getShortCircuitTriggeredBy(): number {
2222
return this._shortCircuitTriggeredBy;
2323
}
2424

25-
get err(): any {
25+
getErr(): any {
2626
return this._err;
2727
}
2828

29-
get errEncounteredAt(): number {
29+
getErrEncounteredAt(): number {
3030
return this._errEncounteredAt;
3131
}
3232

src/interceptor-response-wrapper-builder-internal.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ export class InterceptorResponseWrapperBuilderInternal extends InterceptorRespon
2323
} else {
2424
const request: InterceptorRequestInternal = <InterceptorRequestInternal>from;
2525
InterceptorUtils.assign(builder, request);
26-
if (request.shortCircuitAtCurrentStep) {
27-
builder._shortCircuitTriggeredBy = interceptorStep - 1;
28-
builder._forceRequestCompletion = request.alsoForceRequestCompletion;
26+
if (request.getShortCircuitAtCurrentStep()) {
27+
builder.shortCircuitTriggeredBy(interceptorStep - 1)
28+
.forceRequestCompletion(request.getAlsoForceRequestCompletion());
2929
}
3030
}
3131
return builder;

src/interceptor-service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,14 +170,14 @@ export class InterceptorService extends Http {
170170
return this.runBeforeInterceptors(request)
171171
.flatMap<InterceptorRequest, InterceptorResponseWrapper>((transformedRequest: InterceptorRequest, _: number) => {
172172
const transformedRequestInternal = <InterceptorRequestInternal>transformedRequest;
173-
const interceptorRequestInternal = InterceptorRequestBuilderInternal.new(transformedRequestInternal);
173+
const interceptorRequestInternalBuilder = InterceptorRequestBuilderInternal.new(transformedRequestInternal);
174174

175-
if (interceptorRequestInternal.getErr() || interceptorRequestInternal.getAlreadyShortCircuited()) {
175+
if (interceptorRequestInternalBuilder.getErr() || interceptorRequestInternalBuilder.getAlreadyShortCircuited()) {
176176
const responseWrapper = InterceptorResponseWrapperBuilderInternal
177177
.newInternal(this.interceptors.length, transformedRequestInternal)
178178
.build();
179179
return Observable.of(responseWrapper);
180-
} else if (interceptorRequestInternal.getShortCircuitAtCurrentStep()) {
180+
} else if (interceptorRequestInternalBuilder.getShortCircuitAtCurrentStep()) {
181181
const responseWrapper = InterceptorResponseWrapperBuilderInternal
182182
.newInternal(this.interceptors.length, transformedRequestInternal)
183183
.build();

0 commit comments

Comments
 (0)