Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: 1j01/textual-paint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: 1j01/textual-paint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: mainly-main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Nov 11, 2024

  1. Avoid accessing styles.margin 

    `self.canvas.virtual_region.offset` is basically
`self.canvas.styles.margin.left/top`, but slightly less coupled to CSS.
    @1j01
    1j01 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    54f2aa7 View commit details
    Browse the repository at this point in the history

  2. Fix some View Bitmap behavior 

    - Fix exiting View Bitmap mode with Escape key.
- Avoid CharInput or other widgets keeping focus when entering
  View Bitmap mode.
- Return after handling key as toggling View Bitmap mode, to avoid
  double-acting.
  Note that double-acting is not entirely fixed. (I also added a note
  of a couple of concrete cases where it's double-acting when exiting
  View Bitmap mode, to the known issues list, for future testing.)
- Close menus when entering View Bitmap mode.
    @1j01
    1j01 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    844de0e View commit details
    Browse the repository at this point in the history

  3. Add to known issues list

    @1j01
    1j01 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f233e17 View commit details
    Browse the repository at this point in the history
Loading