Merge pull request brefphp#43 from vhenzl/pr/fix-42

Make sure `/tmp/log` dir exists

Author: mnapoli

src/BrefKernel.php

@@ -62,6 +62,7 @@ public function handle($request, $type = HttpKernelInterface::MASTER_REQUEST, $c
     public function boot()
     {
         $this->prepareCacheDir(parent::getCacheDir(), $this->getCacheDir());
+        $this->ensureLogDir($this->getLogDir());
 
         parent::boot();
     }
@@ -122,6 +123,22 @@ protected function prepareCacheDir(string $readOnlyDir, string $writeDir): void
         ));
     }
 
+    /**
+     * Even though applications should never write into it on Lambda, there are parts of Symfony
+     * (like "about" CLI command) that expect the log dir exists, so we have to make sure of it.
+     *
+     * @see https://github.com/brefphp/symfony-bridge/issues/42
+     */
+    private function ensureLogDir(string $writeLogDir): void
+    {
+        if (! $this->isLambda() || is_dir($writeLogDir)) {
+            return;
+        }
+
+        $filesystem = new Filesystem;
+        $filesystem->mkdir($writeLogDir);
+    }
+
     /**
      * This method logs to stderr.
      *

tests/Functional/FunctionalTest.php

@@ -14,7 +14,7 @@ abstract class FunctionalTest extends TestCase
      * simulate a persistent `/tmp` directory, just like inside AWS Lambda.
      * This will also let us check the content of that directory.
      */
-    private const LOCAL_TMP_DIRECTORY = __DIR__ . '/App/tmp';
+    protected const LOCAL_TMP_DIRECTORY = __DIR__ . '/App/tmp';
 
     public function setUp(): void
     {

tests/Functional/LogDirTest.php

@@ -0,0 +1,44 @@
+<?php declare(strict_types=1);
+
+namespace Bref\SymfonyBridge\Test\Functional;
+
+use Symfony\Component\Filesystem\Filesystem;
+
+/**
+ * Test /tmp/log is created
+ */
+class LogDirTest extends FunctionalTest
+{
+    public function setUp(): void
+    {
+        parent::setUp();
+        $this->composerInstall();
+        $this->clearTempLog();
+    }
+
+    private function clearTempLog(): void
+    {
+        (new Filesystem)->remove(self::LOCAL_TMP_DIRECTORY . '/log');
+    }
+
+    public function test Symfony works(): void
+    {
+        $this->assertCommandIsSuccessful($this->runHttpRequest());
+    }
+
+    public function test log dir is created in tmp on http request(): void
+    {
+        $this->assertDirectoryNotExists(self::LOCAL_TMP_DIRECTORY . '/log');
+
+        $this->runHttpRequest();
+        $this->assertDirectoryExists(self::LOCAL_TMP_DIRECTORY . '/log');
+    }
+
+    public function test log dir is created in tmp on console command(): void
+    {
+        $this->assertDirectoryNotExists(self::LOCAL_TMP_DIRECTORY . '/log');
+
+        $this->runSymfonyConsole('about');
+        $this->assertDirectoryExists(self::LOCAL_TMP_DIRECTORY . '/log');
+    }
+}