Generalise auto-restart logic to support workloads other than Deployments #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lets use the same general structure and env variables to control if a workload (i.e. a deployment, statefulset, daemonset etc.) should automatically be restarted - we can add better control for different resource types later if required
…loads - Replaced deployment-specific logic with generalized handling for supported workloads - Additional workload types can be marked as support in the `restartWorkload` function once their corresponding controller is implemented
…e for multiple types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactors the auto-restart logic for workloads referencing 1Password-managed secrets. It generalises internal logic to allow future support for non-Deployment workload types (i.e. stateful sets, daemon sets) while preserving existing behaviour.
client.Objectorruntime.ObjectThe next steps should this implementation be approved would be to implement controllers for each of the remaining workloads. I believe the current controller could also be genericised in a similar way seen in this PR – which would be ideal as otherwise we'd need to think about how secrets are cleaned up when they're shared by multiple workloads/controllers.
A demo of this implementation working for DaemonSets can be found at: https://github.com/jmsnll/onepassword-operator/tree/feat/demo-daemonsets-autorestart
Related Issue(s)
Changelog
GetPodTemplateextracts pod template from known workload typesGetUpdatedSecretsForPodTemplateresolves updated secrets from a pod specruntime.Objectfor workload definitions