improve vault and item parsing #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By replacing string.Split in ParseVaultAndItemFromPath with a regexp, you can use vault and item names containing slashes
|
Is there anything I can do to help with the required review? |
AndyTitu
reviewed
Jul 14, 2025
| if len(splitPath) == 4 && splitPath[0] == "vaults" && splitPath[2] == "items" { | ||
| return splitPath[1], splitPath[3], nil | ||
| r := regexp.MustCompile("vaults/(.*)/items/(.*)") | ||
| splitPath := r.FindAllStringSubmatch(path, -1) |
There was a problem hiding this comment.
A little bit shorter but does the same thing:
Suggested change
| splitPath := r.FindAllStringSubmatch(path, -1) | |
| splitPath := r.FindStringSubmatch(path) |
since we expect a single match anyway. Otherwise, injecting another vaults/.../items/... in the path could lead to an unexpected result.
We could also add another unit test case for the vaults/foo1/items/bar1/vaults/foo2/items/bar2 example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By replacing string.Split in ParseVaultAndItemFromPath with a regexp,
you can use vault and item names containing slashes