Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect exposed as NodePort service by default #194

Open
bo0tzz opened this issue May 6, 2024 · 0 comments
Open

Connect exposed as NodePort service by default #194

bo0tzz opened this issue May 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@bo0tzz
Copy link

bo0tzz commented May 6, 2024

Your environment

Chart Version: current

What happened?

The default configuration for the onepassword-connect service created by this chart is to expose it as a NodePort. In many environments this can result in the service being directly open to the internet. I don't know whether this causes any direct security problems (I think it still has authentication?), but it is at the very least a very concerning thing to unexpectedly discover.

What did you expect to happen?

For the default service type to be ClusterIP, internal to the cluster network.

Notes & Logs

#65 made the service type configurable, where before it was hardcoded as NodePort. A comment on that PR noted that the default should be ClusterIP, but this did not get picked up on at the time.

@bo0tzz bo0tzz added the bug Something isn't working label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant