Skip to content

fix: Cannot copy applications with opening statement characters exceeding 4096 #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

shaohuzhang1
Copy link
Contributor

fix: Cannot copy applications with opening statement characters exceeding 4096

Copy link

f2c-ci-robot bot commented Apr 29, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -495,7 +495,7 @@ class Edit(serializers.Serializer):
min_value=0,
max_value=1024,
error_messages=ErrMessage.integer(_("Historical chat records")))
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=4096,
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=102400,
error_messages=ErrMessage.char(_("Opening remarks")))
dataset_id_list = serializers.ListSerializer(required=False, child=serializers.UUIDField(required=True),
error_messages=ErrMessage.list(_("Related Knowledge Base"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of issues in this code snippet:

  1. The allow_blank=True parameter is typically used with fields that accept Unicode strings (like text areas) instead of character strings (like single-line text). So the appropriate field type should be something like CharField, not Serializers.CharField. You can remove the allow_blank=True if you intended to use something else.

Here's an optimized version assuming UTF-8 encoding:

class Edit(serializers.Serializer):
    historical_chat_count = serializers.IntegerField(
                                required=False,
                                default=0,
                                min_value=0,
                                max_value=1024,
                                error_messages=dict(min_value=_('Minimum value: 0'),
                                                  max_value=_('Maximum value: 1024'))
                            )
    prologue = serializers Charfield(
                      required=False,
                      blank=True,
                      max_length=102400,   # Assuming maximum length of utf-8 characters
                      error_messages=dict(required=_('Prologue is required'))
                  )
    dataset_id_list = serializers.ListSerializer(
                         required=False,
                         child=serializers.UUIDField(),
                         allow_null=True,
                         error_messages=dict(max_length=_('Dataset ID list cannot be longer than allowed'))
                     )

Additionally, ensure all other fields follow the same logic as well, using the correct fields from Django REST Framework and adhering to best naming conventions for variables and attributes within classes.

@shaohuzhang1 shaohuzhang1 merged commit 0c7cca0 into main Apr 29, 2025
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_copy_application branch April 29, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant