-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: Cannot copy applications with opening statement characters exceeding 4096 #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -495,7 +495,7 @@ class Edit(serializers.Serializer): | |||
min_value=0, | |||
max_value=1024, | |||
error_messages=ErrMessage.integer(_("Historical chat records"))) | |||
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=4096, | |||
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=102400, | |||
error_messages=ErrMessage.char(_("Opening remarks"))) | |||
dataset_id_list = serializers.ListSerializer(required=False, child=serializers.UUIDField(required=True), | |||
error_messages=ErrMessage.list(_("Related Knowledge Base")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of issues in this code snippet:
- The
allow_blank=True
parameter is typically used with fields that accept Unicode strings (like text areas) instead of character strings (like single-line text). So the appropriate field type should be something likeCharField
, notSerializers.CharField
. You can remove theallow_blank=True
if you intended to use something else.
Here's an optimized version assuming UTF-8 encoding:
class Edit(serializers.Serializer):
historical_chat_count = serializers.IntegerField(
required=False,
default=0,
min_value=0,
max_value=1024,
error_messages=dict(min_value=_('Minimum value: 0'),
max_value=_('Maximum value: 1024'))
)
prologue = serializers Charfield(
required=False,
blank=True,
max_length=102400, # Assuming maximum length of utf-8 characters
error_messages=dict(required=_('Prologue is required'))
)
dataset_id_list = serializers.ListSerializer(
required=False,
child=serializers.UUIDField(),
allow_null=True,
error_messages=dict(max_length=_('Dataset ID list cannot be longer than allowed'))
)
Additionally, ensure all other fields follow the same logic as well, using the correct fields from Django REST Framework and adhering to best naming conventions for variables and attributes within classes.
fix: Cannot copy applications with opening statement characters exceeding 4096