Skip to content

feat: Support Alibaba Bailian supplier qwen3 model #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

shaohuzhang1
Copy link
Contributor

feat: Support Alibaba Bailian supplier qwen3 model

Copy link

f2c-ci-robot bot commented Apr 29, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit a6533c0 into main Apr 29, 2025
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@feat_qwen3_model branch April 29, 2025 06:57
for res in model.stream([HumanMessage(content=gettext('Hello'))]):
pass
else:
model.invoke([HumanMessage(content=gettext('Hello'))])
except Exception as e:
traceback.print_exc()
if isinstance(e, AppApiException):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code provided has a few minor improvements that can be made:

  1. Handling Stream Mode: The model.stream method is only being called when model_params.get('stream') is truthy.
  2. Explicitly Handling None Types: If res in the stream mode returns None, it will not throw an exception but simply go to the next iteration of the loop.

Here's the updated code with these improvements included:

@@ -47,7 +47,12 @@
                 return False

         try:
             model = provider.get_model(model_type, model_name, model_credential, **model_params)
-            model.invoke([HumanMessage(content=gettext('Hello'))])
+            if 'stream' in model_params and model_params['stream']:
+                for res in model.stream([HumanMessage(content=gettext('Hello'))]):
+                    # Handle streaming output here, e.g., print(res)
+                    pass
+            else:
+                model.invoke([HumanMessage(content=gettext('Hello'))])

         except Exception as e:
             traceback.print_exc()
             if isinstance(e, AppApiException):

Additionally, consider adding error handling around any operations within the stream loop or where res might be None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant