fix: During the conversation, there is sensitive data in the application profile obtained by the application #3018
Conversation
…ion profile obtained by the application
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -1012,7 +1012,8 @@ def profile(self, with_valid=True): | |||
| 'stt_autosend': application.stt_autosend, | |||
| 'file_upload_enable': application.file_upload_enable, | |||
| 'file_upload_setting': application.file_upload_setting, | |||
| 'work_flow': application.work_flow, | |||
| 'work_flow': {'nodes': [node for node in application.work_flow.get('nodes') if | |||
| node.get('id') == 'base-node']}, | |||
| 'show_source': application_access_token.show_source, | |||
| 'language': application_access_token.language, | |||
| **application_setting_dict}) | |||
There was a problem hiding this comment.
The main change in this function is removing all but one workflow node from application.work_flow.nodes before serializing it to JSON. This could potentially cause issues if the application relies on other nodes defined in the original workflow.
Potential improvements:
- Remove unnecessary code: The line
if 'base-node' in [node.get('id') for node in ...]:can be simplified or removed entirely since you're already checking against a specific ID later. - Consider adding error handling: It might be good to add a try-except block around operations involving parsing or accessing data within the workflow structure.
fix: During the conversation, there is sensitive data in the application profile obtained by the application