Skip to content

fix: The local rearrangement model cannot be loaded #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

fix: The local rearrangement model cannot be loaded #2805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/setting/models_provider/impl/local_model_provider/model/reranker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class LocalBaseReranker(MaxKBBaseModel, BaseDocumentCompressor):
tokenizer: Any = None
model: Optional[str] = None
cache_dir: Optional[str] = None
model_kwargs: ClassVar = {}
model_kwargs: Any = {}

def __init__(self, model_name, cache_dir=None, **model_kwargs):
super().__init__()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has a minor issue with incorrect typing for model_kwargs. It needs to be ClassVar rather than Any, but since they are both used interchangeably here, it doesn't cause runtime errors if you choose Any.

Here's the corrected version of the code:

@@ -72,8 +72,8 @@
         tokenizer: Any = None
         model: Optional[str] = None
         cache_dir: Optional[str] = None
-        model_kwargs: ClassVar = {} # Incorrectly defined as 'ClassVar'
+        model_kwargs: Any = {}

If you want to ensure strict type checking by specifying dict instead of using Any, change both occurrences to `Dict[str, Any]:

class LocalBaseReranker(BaseKBBaseModel, BaseDocumentCompressor):
    tokenizer: Any = None
    model: Optional[str] = None
    cache_dir: Optional[str] = None
    model_kwargs: Dict[str, Any] = {}  # Corrected to accept only strings as keys

    def __init__(self, model_name, cache_dir=None, **model_kwargs):
        super().__init__()

Suggested Optimization:

  1. Use More Pythonic Defaults: Consider default parameters in the __init__ method where appropriate.
  2. Ensure Type Hint Consistency: Always use specific types (e.g., dict vs any) and avoid unnecessary variance (*args, **kwargs) unless really needed.

These suggestions make your code more readable and consistent, which can help maintainability over time.

Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ diskcache = "^5.6.3"
pillow = "^10.2.0"
filetype = "^1.2.0"
torch = "2.6.0"
sentence-transformers = "^2.2.2"
sentence-transformers = "^4.0.2"
openai = "^1.13.3"
tiktoken = "^0.7.0"
qianfan = "^0.3.6.1"
Expand Down Expand Up @@ -66,6 +66,7 @@ pysilk = "^0.0.1"
django-db-connection-pool = "^1.2.5"
opencv-python-headless = "^4.11.0.86"
pymysql = "^1.1.1"
accelerate = "^1.6.0"
[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"
Expand Down