Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Excerpt from the thinking process #2181

Merged
merged 1 commit into from
Feb 9, 2025
Merged

fix: Excerpt from the thinking process #2181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/application/flow/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ def get_reasoning_content(self, chunk):
self.reasoning_content_is_start = True
self.reasoning_content_chunk = self.all_content[self.reasoning_content_start_tag_len:]
else:
self.reasoning_content_is_end = True
if not self.reasoning_content_is_end:
self.reasoning_content_is_end = True
self.content += self.all_content
return {'content': self.all_content, 'reasoning_content': ''}
else:
if self.reasoning_content_is_start:
self.reasoning_content_chunk += chunk.content
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no immediate issues with the provided code snippet. However, there is an unnecessary assignment within the if statement to modify self.reasoning_content_is_end.

I suggest optimizing it by removing that line since it unnecessarily increments the length of self.reasoning_content. Also, ensure that return {'content': '', 'reasoning_content': ''} is correctly placed within a conditional block where it makes sense to handle when both content parts have been fully collected.

Optimized version:

def get_reasoning_content(self, chunk):
    if self.reasoning_content_is_start:
        self.reasoning_content_chunk += chunk.content

    elif not self.reasoning_content_is_complete:
        # Check if we've reached the end tag
        if 'end_of_reaso' in chunk.all_content.strip():  # Adjust condition based on actual tagging
            self.reasoning_content_is_end = True
            self.all_content += chunk.all_content
            return {'content': "", 'reasoning_content': self.reasoning_content_chunk}

    else:  # Both chunks processed
        return {'content': self.all_content, 'reasoning_content': self.reasoning_content_chunk}

In this version, I assume that you meant to include additional logic to check for the end tag (end_of_reaso) and process the concatenated results appropriately. If this isn't the case, please adjust accordingly.

Expand Down