-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: Application history log interface loading status display error #2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this code snippet, there are several minor improvements and optimizations:
Type Annotations: Replace
any
withRef<any>
to improve type safety while utilizing Vue's reactivity system.Use of Parameters: The parameter definition for the
getDetail
function allows passing an optional boolean (isLoading
) which sets the loading status dynamically. This is beneficial when you want to control whether the loading should occur or not based on certain conditions.Function Parameter Naming: Changed
id as string
to justid
since it can be reliably converted to a string during the function call without needing explicit casting.These changes enhance the readability, maintainability, and performance of the code by improving typesafety and reducing unnecessary conversions.