Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏁 Publish the new 18F site #3967

Closed
48 tasks done
Tracked by #3839
beechnut opened this issue Jul 2, 2024 · 9 comments
Closed
48 tasks done
Tracked by #3839

🏁 Publish the new 18F site #3967

beechnut opened this issue Jul 2, 2024 · 9 comments
Assignees

Comments

@beechnut
Copy link
Contributor

beechnut commented Jul 2, 2024

The 18F main branch has changed since we started the replatforming. I'm aware of several blog posts, at least one additional author, and some style changes relating to code blocks.

Tasks

Acceptance criteria

Tasks

  1. type:bug
    beechnut
  2. type:bug
    beechnut
  3. type:bug
    beechnut
  4. type:bug
    beechnut
  5. type:bug
    beechnut
  6. type:bug
    beechnut
  7. type:bug
  8. type:bug
    beechnut
  9. type:bug
    beechnut
  10. type:bug
    beechnut
  11. type:bug
    beechnut
  12. type:bug
    beechnut
  13. type:bug
    beechnut
@beechnut beechnut changed the title Migrate content and style changes from main Publish the new 18F site Jul 2, 2024
@beechnut beechnut changed the title Publish the new 18F site 🏁 Publish the new 18F site Jul 2, 2024
@adunkman
Copy link
Member

adunkman commented Aug 2, 2024

Assigning @beechnut since they moved it to in progress — @beechnut flag if you’d like someone else from TLC to pick this up.

@beechnut
Copy link
Contributor Author

beechnut commented Aug 9, 2024

@cantsin Is that everything?? Is it time to freeze, migrate, and merge???

@cantsin
Copy link
Member

cantsin commented Aug 9, 2024

It's Friday afternoon, traditionally the best time to merge new code 🎉 Surely nothing can go wrong over the weekend!

Yes, let's freeze. And plan to officially migrate/merge next week?

@beechnut
Copy link
Contributor Author

beechnut commented Aug 9, 2024

Sounds good to me!

@beechnut
Copy link
Contributor Author

Ok, here's where we're at: #4050 has the latest changes and gets us ready to release.

Things that aren't perfect:

  • Code block styling doesn't have line numbers, and it'll take more time than I want to spend on that to get it ready and perfect. I'm ok leaving line numbers off, knowing I'll prioritize this in post-migration changes.
  • There's still a lot of site.baseurls. I thought that migrating this was essential for release, but it appears to be more of a nice-to-have. Whenever I check them, internal links work, assets render. I'm not anticipating any negative consequences from this.

With those noted in #3864 , how would we feel about flipping the switch and merging later today?

@beechnut
Copy link
Contributor Author

Just merged #4058 and checked off the last 13 tasks! Thanks @cantsin for finding all of those and fixing most of them!

@beechnut
Copy link
Contributor Author

@cantsin... are we ready?

@cantsin
Copy link
Member

cantsin commented Aug 16, 2024

so super excited to see all this work finally come to fruition 🎉 LETS DOOOO IT

@beechnut
Copy link
Contributor Author

Nicely done, all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants