Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validations should be revisited #447

Open
1602 opened this issue Jul 31, 2016 · 0 comments
Open

Validations should be revisited #447

1602 opened this issue Jul 31, 2016 · 0 comments

Comments

@1602
Copy link
Owner

1602 commented Jul 31, 2016

  • deprecate sync validations
  • callback with error only (reject promise) instead of collecting errors on instance
  • think of readable error messages instead of 'Validation error'
  • fail after first validation error, when saving
  • support validateAll method which will perform all validations and collect errors to replace previous functinality of instance.errors after .isValid()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant