Several enhancements

Author: 14code

lib/Action.php

@@ -11,5 +11,65 @@
 
 class Action
 {
+    private $name = '';
+    private $type = '';
+    private $target;
 
+    /**
+     * Action constructor.
+     * @param string $name
+     * @param string $type
+     */
+    public function __construct(string $type)
+    {
+        $this->type = $type;
+    }
+
+    /**
+     * @return string
+     */
+    public function getName(): string
+    {
+        return $this->name;
+    }
+
+    /**
+     * @param string $name
+     */
+    public function setName(string $name): void
+    {
+        $this->name = $name;
+    }
+
+    /**
+     * @return string
+     */
+    public function getType(): string
+    {
+        return $this->type;
+    }
+
+    /**
+     * @param string $type
+     */
+    public function setType(string $type): void
+    {
+        $this->type = $type;
+    }
+
+    /**
+     * @return mixed
+     */
+    public function getTarget()
+    {
+        return $this->target;
+    }
+
+    /**
+     * @param mixed $target
+     */
+    public function setTarget(Model $target): void
+    {
+        $this->target = $target;
+    }
 }

lib/Trello.php

@@ -101,4 +101,8 @@ public function getLists(Model $board)
         return $lists;
     }
 
+    public function registerWebhook(Webhook)
+    {
+    }
+
 }

lib/Webhook.php

@@ -11,5 +11,81 @@
 
 class Webhook
 {
+    private $action;
+    private $id;
+    private $model;
+    private $handle;
+
+    /**
+     * @return mixed
+     */
+    public function getAction()
+    {
+        return $this->action;
+    }
+
+    /**
+     * @param mixed $action
+     * @return Webhook
+     */
+    public function setAction($action)
+    {
+        $this->action = $action;
+        return $this;
+    }
+
+    /**
+     * @return mixed
+     */
+    public function getId()
+    {
+        return $this->id;
+    }
+
+    /**
+     * @param mixed $id
+     * @return Webhook
+     */
+    public function setId($id)
+    {
+        $this->id = $id;
+        return $this;
+    }
+
+    /**
+     * @return mixed
+     */
+    public function getModel()
+    {
+        return $this->model;
+    }
+
+    /**
+     * @param mixed $model
+     * @return Webhook
+     */
+    public function setModel($model)
+    {
+        $this->model = $model;
+        return $this;
+    }
+
+    /**
+     * @return mixed
+     */
+    public function getHandle()
+    {
+        return $this->handle;
+    }
+
+    /**
+     * @param mixed $handle
+     * @return Webhook
+     */
+    public function setHandle($handle)
+    {
+        $this->handle = $handle;
+        return $this;
+    }
 
 }

tests/ActionTest.php

@@ -12,10 +12,35 @@
 
 class ActionTest extends \PHPUnit\Framework\TestCase
 {
-    public function testObject()
+    protected $action;
+
+    public function setUp(): void
+    {
+    }
+
+    public function testCreateAction()
+    {
+        $action = new Action("return");
+        $action->setName('Returns the string \'Executed\'');
+        $this->assertTrue(true);
+        return $action;
+    }
+
+    /**
+     * @depends testCreateAction
+     */
+    public function testGetName($action)
+    {
+        $this->assertEquals("Returns the string 'Executed'", $action->getName());
+    }
+
+    /**
+     * @depends testCreateAction
+     */
+    public function testSetName($action)
     {
-        $object = new Action();
-        $this->assertIsObject($object,"Has to be an object.");
+        $action->setName("New name");
+        $this->assertEquals("New name", $action->getName());
     }
 
 }

tests/TrelloTest.php

@@ -17,18 +17,26 @@ public function init($msg = "")
         }
     }
 
+    public function testInit()
+    {
+        require ".config";
+        $trello = new \Webhooks\Wrapper\Trello($key, $token);
+        $this->assertTrue(true);
+        return $trello;
+    }
+
     public function teamIdProvider()
     {
         return [['5c004b2157cb628ef3fd9362']];
     }
 
     /**
+     * @depends testInit
      * @dataProvider teamIdProvider
      */
-    public function testGetTeam($id)
+    public function testGetTeam()
     {
-        $this->init();
-        $trello = $this->trello;
+        list($id, $trello) = func_get_args();
         $team = $trello->getTeam($id);
         $this->assertInstanceOf("Webhooks\Wrapper\Model", $team, "Only Model object required");
         $this->assertEquals("team", $team->getType(), "Model should be of type team");
@@ -62,6 +70,7 @@ public function selectTestTeamProvider()
     }
 
     /**
+     * @depends testInit
      * @dataProvider teamsProvider
      */
     public function testGetTeamsReturnedModels($model)