Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc example to install WP_Mock via composer #214

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

unfulvio-godaddy
Copy link
Member

Summary

Fixes instruction for installing WP_Mock package via composer, along with adding doc and readme improvements.

Closes: #213

Details

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

  • Consult updated README.md file and affected doc pages

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy self-assigned this Jun 15, 2023
@unfulvio-godaddy unfulvio-godaddy requested a review from a team June 15, 2023 07:53
@coveralls
Copy link

Coverage Status

coverage: 43.396%. remained the same when pulling fdfdad9 on chore/fix-documentation-instructions into 8961bda on trunk.

@unfulvio-godaddy unfulvio-godaddy removed the request for review from a team June 15, 2023 09:46
@unfulvio-godaddy unfulvio-godaddy merged commit 9ce8001 into trunk Jun 16, 2023
@unfulvio-godaddy unfulvio-godaddy deleted the chore/fix-documentation-instructions branch June 16, 2023 01:51
@jeffpaul jeffpaul added this to the 0.6.0 milestone Jun 23, 2023
@unfulvio-godaddy unfulvio-godaddy removed this from the 0.6.0 milestone Jun 26, 2023
@unfulvio-godaddy
Copy link
Member Author

@jeffpaul this wasn't added to a milestone because documentation isn't part of a release, and changes are/were instant, so it didn't belong to a release

@jeffpaul
Copy link
Member

@unfulvio-godaddy we still tend to include PRs merged during a release cycle but not typically part of the release software in the same milestone. The reasoning here being if we're trying to triage things that happened around that timeframe we have good context of what happened then.

@jeffpaul jeffpaul added this to the v1.0.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Updates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation bug: wp:mock instead of wp_mock
5 participants